[tracking] (desktop) Update localized search plugins with resultdomain

VERIFIED FIXED in Firefox 31

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mak, Assigned: flod)

Tracking

unspecified
Firefox 31
Points:
---
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: p=0 s=it-32c-31a-30b.1 [qa!])

Reporter

Description

5 years ago
the en-us plugins are already updated, though localized ones are not.
resultdomain is the root domain of the search engine, for www.google.com it's google.com, for search.creativecommons.org it's creativecommons.org... It's the domain we will complete in the awesomebar to drive the user to the search engine provider main page.
Assignee

Comment 1

5 years ago
Can you elaborate a bit on the change – i.e. what happens if we don't update the localized searchplugins, involves only Firefox or also Fennec – and the timeline? 

Because we're talking about hundreds of searchplugins/file, and it's really painful doing changes there (and it would be the third time in 12 months, with a fourth almost ready for Yahoo…).
Assignee

Comment 2

5 years ago
Make request explicit with NI
Flags: needinfo?(mak77)
Reporter

Comment 3

5 years ago
(In reply to Marco Bonardo [:mak] from comment #0)
> the en-us plugins are already updated, though localized ones are not.
> resultdomain is the root domain of the search engine, for www.google.com
> it's google.com, for search.creativecommons.org it's creativecommons.org...
> It's the domain we will complete in the awesomebar to drive the user to the
> search engine provider main page.

we are building a new autocomplete search that will match against those strings, not providing a resultDomain means we will try to use the host, that in some cases will match properly, in other cases it will match wrongly (for example "s" will match "search.creative.commons.org" while it would be expected "c" to match "creativecommons.org"). For the most common cases like google or bing it should work regardless since they don't use "special" search subdomains, so let's say it's not something that will break the world.
Regarding a timeframe for the change, I think in v32 we may enable that component in Nightly.
Flags: needinfo?(mak77)
Assignee

Comment 4

5 years ago
Luckily Google and Bing are not a problem, since locales rely on en-US versions.
I'll need to review Yahoo as part of bug 994141, so I'll fix that too.

I'm wondering about cases like zh-TW
http://transvision.mozfr.org/productization/?locale=zh-TW&product=browser

They have a bunch of *.yahoo.com searchplugins, so my guess is that the autocomplete will produce more results.
Assignee: nobody → francesco.lodolo
Assignee

Updated

5 years ago
Depends on: 994248
Assignee

Comment 5

5 years ago
Last question (I think): is this something that targets only desktop or mobile too? I didn't see landings for the latter so far.
Flags: needinfo?(mak77)
Reporter

Comment 6

5 years ago
only desktop afaik
Flags: needinfo?(mak77)
Reporter

Comment 7

5 years ago
(In reply to Francesco Lodolo [:flod] from comment #4)
> I'm wondering about cases like zh-TW
> http://transvision.mozfr.org/productization/?locale=zh-TW&product=browser
> 
> They have a bunch of *.yahoo.com searchplugins, so my guess is that the
> autocomplete will produce more results.

interesting question, we may have to tweak matching for those, or just suggest the main search page and then from there users can go anywhere. The idea is to make easier to reach the search engines from the awesomebar, I don't think the design went so deep to allow searching for sub-sections of the engines.
the problem here is what users should type to reach these different sub-engines, typing y will clearly match yahoo, the generic search page.
Flags: needinfo?(clarkbw)
Flags: firefox-backlog?
(In reply to Marco Bonardo [:mak] from comment #7)
> (In reply to Francesco Lodolo [:flod] from comment #4)
> > I'm wondering about cases like zh-TW
> > http://transvision.mozfr.org/productization/?locale=zh-TW&product=browser
> > 
> > They have a bunch of *.yahoo.com searchplugins, so my guess is that the
> > autocomplete will produce more results.
> 
> interesting question, we may have to tweak matching for those, or just
> suggest the main search page and then from there users can go anywhere. The
> idea is to make easier to reach the search engines from the awesomebar, I
> don't think the design went so deep to allow searching for sub-sections of
> the engines.
> the problem here is what users should type to reach these different
> sub-engines, typing y will clearly match yahoo, the generic search page.

Indeed the intention wasn't to have lots of sub domains however I can see how both ways have merit.  For simplicity I would think we'd want to just offer the top level and allow people to create history from that point but I'm open to the alternate view here.
Flags: needinfo?(clarkbw)
Flags: firefox-backlog? → firefox-backlog+
Whiteboard: p=0
Assignee

Updated

5 years ago
Summary: Update localized search plugins with resultdomain → (desktop) Update localized search plugins with resultdomain
Assignee

Comment 9

5 years ago
I'll be using this bug as a tracker for changes, probably good to move the discussion about subdomains into a different one? Flood incoming.
Summary: (desktop) Update localized search plugins with resultdomain → [tracking] (desktop) Update localized search plugins with resultdomain
Assignee

Comment 10

5 years ago
Changes are pushed to both mozilla-aurora and l10n-central. 

After discussing this with mak on IRC, I'm adding resultdomain even when it's not strictly necessary (e.g. amazon), at least it's easier to check later if searchplugins regress.

af: http://hg.mozilla.org/releases/l10n/mozilla-aurora/af/rev/5756d9ed3103
an: http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/32c4c7f9e252
ar: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/b22b38727d48
as: http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/09e591c53bbb
ast: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ast/rev/540971be5bf0
be: http://hg.mozilla.org/releases/l10n/mozilla-aurora/be/rev/0d26f3e874df
bg: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bg/rev/a36cb95311ec
bn-BD: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-BD/rev/1fd0eb180ef5
bn-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/eabff74c6e09
br: http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/d0c6d4187bfd
ca: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/bd33352907b3
cs: http://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/5e3dcd25b1cc
csb: http://hg.mozilla.org/releases/l10n/mozilla-aurora/csb/rev/e9869ab83b7a
cy: http://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/rev/e8340c7d2bb5
da: http://hg.mozilla.org/releases/l10n/mozilla-aurora/da/rev/90ae45e22e8c
de: http://hg.mozilla.org/releases/l10n/mozilla-aurora/de/rev/b4111bf68a76
Assignee

Comment 12

5 years ago
eo: http://hg.mozilla.org/releases/l10n/mozilla-aurora/eo/rev/98852af0c832
es-AR:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-AR/rev/bca7f690a470
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-AR/rev/323e7f2db2f4
es-CL:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-CL/rev/eb77fd58ccf5
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-CL/rev/12eaa35db1d1
es-ES: http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-ES/rev/e19866337e6d
es-MX: http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-MX/rev/8336a58bd3f2
et: http://hg.mozilla.org/releases/l10n/mozilla-aurora/et/rev/674e23e4c65a
eu: http://hg.mozilla.org/releases/l10n/mozilla-aurora/eu/
fa: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/855ee207e514
ff: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ff/rev/0725ba590f61
fi: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/rev/5160c4282889
fr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/a26f60e03ca8
fy-NL: http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/71ac99d52d97
ga-IE: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/9b4d117a6b4b
gd:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gd/rev/0585c5720d5e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gd/rev/ab4efd2371f7
gl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/gl/rev/ac829782e264
gu-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/gu-IN/rev/2a3be775fe9e
Assignee

Comment 15

5 years ago
mai: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mai/rev/bece8ded177a
mk: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mk/rev/5001df852c38
ml: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ml/rev/d262798f8853
mn: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mn/rev/c10e10811a45
mr: http://hg.mozilla.org/releases/l10n/mozilla-aurora/mr/rev/7b391741d29c
ms: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ms/rev/d780d3f2506c
my: http://hg.mozilla.org/releases/l10n/mozilla-aurora/my/rev/14c962567218
nb-NO: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nb-NO/rev/645ff0f02ae7
nl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/rev/157ff657573e
nn-NO: http://hg.mozilla.org/releases/l10n/mozilla-aurora/nn-NO/rev/379a73e344bf
oc: http://hg.mozilla.org/releases/l10n/mozilla-aurora/oc/rev/9fc807aa3c9d
or: http://hg.mozilla.org/releases/l10n/mozilla-aurora/or/rev/ba532d42bd19
pa-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pa-IN/rev/7635c76c7337
pl: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pl/rev/4031e1957ca0
pt-BR: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-BR/rev/e60c6067d75e
pt-PT: http://hg.mozilla.org/releases/l10n/mozilla-aurora/pt-PT/rev/94cdd15a0504
rm: http://hg.mozilla.org/releases/l10n/mozilla-aurora/rm/rev/1c6baa4acf2e
ro: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/9ac8f078f46c
ru: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ru/rev/dca13a9b57cb
Assignee

Comment 18

5 years ago
Double checked l10n-central and mozilla-aurora, this should be done.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Whiteboard: p=0 → p=0 s=IT-32C-31A-30B.1
Marco, do you need QA testing for this as part of the iteration? Is there adequate automated coverage for these changes?
Flags: needinfo?(mak77)
Whiteboard: p=0 s=IT-32C-31A-30B.1 → p=0 s=IT-32C-31A-30B.1 [qa+]
Otilia, can you please assign this to someone for testing, pending Marco's feedback? Thanks.
Flags: needinfo?(otilia.anica)
Reporter

Comment 21

5 years ago
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #19)
> Marco, do you need QA testing for this as part of the iteration? Is there
> adequate automated coverage for these changes?

Well, I'm not sure how to test these changes, apart going through all of the changes and check they are sane. There's no UI exposed for this yet.
Flags: needinfo?(mak77)
(In reply to Marco Bonardo [:mak] from comment #21)
> There's no UI exposed for this yet.

Is there any chance these changes could regress existing search functionality in l10n builds?
Assignee

Comment 23

5 years ago
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #22)
> (In reply to Marco Bonardo [:mak] from comment #21)
> > There's no UI exposed for this yet.
> 
> Is there any chance these changes could regress existing search
> functionality in l10n builds?

Yes, if I messed up something. Considering the change was scripted in most of the case (like 99%), it should be decently safe. I have some scripts running that warns me if a .xml is invalid, but that's pretty much all I have.

Anyway, I'm going to send an email out to dev-l10n explaining that I completed this fix and to double check that everything works as expected.
Thanks Francesco, we'll do a manual sanity check against a random selection of locales as well.
Whiteboard: p=0 s=IT-32C-31A-30B.1 [qa+] → p=0 s=it-32c-31a-30b.2 [qa+]
Whiteboard: p=0 s=it-32c-31a-30b.2 [qa+] → p=0 s=it-32c-31a-30b.1 [qa+]

Updated

5 years ago
Flags: needinfo?(otilia.anica)
QA Contact: bogdan.maris
(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #24)
> Thanks Francesco, we'll do a manual sanity check against a random selection
> of locales as well.

We verified that the following locales have the affected search plugins updated with the associated "resultdomain" parameter value and spot-checked search on each of them, using Aurora 31 2014-05-12: fr, es-ES, de, ru, pt-BR, it, th, ja, zh-CN, ko, af, sv-SE, fi, bn-IN, es-MX, ar, he, da, pl, tr, hi-IN, zh-TW, id, kn, fa.  

We tracked our tests in this etherpad [1] and covered the following platforms: Windows 7 64-bit, Windows 8.1 64-bit, Mac OS X 10.9.2 and Ubuntu 13.04 32bit.

Is there anything else we should look at here?

[1] https://etherpad.mozilla.org/31-a2-l10s-RD
Status: RESOLVED → VERIFIED
Whiteboard: p=0 s=it-32c-31a-30b.1 [qa+] → p=0 s=it-32c-31a-30b.1 [qa!]
You need to log in before you can comment on or make changes to this bug.