Closed Bug 994248 Opened 6 years ago Closed 4 years ago

[tracking] Update Yahoo to use SSL (searchplugins, handlers), implement suggestions (all) and add resultdomain (desktop)

Categories

(Mozilla Localizations :: Other, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

Details

Localized versions of Yahoo should use https (en-US was updated in bug 958883).

We should also be able to use suggestions.
http://hg.mozilla.org/mozilla-central/rev/97f2e9782e1c

Example:
http://ff.search.yahoo.com/gossip?output=fxjson&command=test

Also worth adding resultdomain as part of bug 991543
We should also remove any/all top2 conditionals to match bug 983723
In addition: mobile should be ffm, desktop should be ffd
Component: Infrastructure → Other
I see now that bug 958883 has now approval requests for aurora and beta. At this point in the cycle, and with Australis in the middle, I can only target Firefox 31 (so next cycle on aurora) for this update.
That's fine, people asked about it so I'm accelerating things where it's not a giant pain. :)
Good, I'll send a message to dev-l10n before this cycle ends to warn localizers about this change.

Current list of locales with a localized version of Yahoo

Desktop
an, as, ast, bn-IN, br, cy, de, en-GB, es-AR, es-CL, es-ES, es-MX, ff, fi, fr, fy-NL, ga-IE, gd, gl, gu-IN, hi-IN, id, it, ja, ja-JP-mac, kn, lij, mai, mr, nb-NO, oc, or, pa-IN, pt-BR, rm, son, sv-SE, ta, te, zh-TW

Mobile
de, en-GB, es-ES, fi, fr, ja, ja-JP-mac, pt-BR 
(es-MX, id already fixed)
About the suggestion URL: any idea if there is one for Japan? I tried a few variations but could find anything.
Japan is weird, I don't think they even support SSL at present.  Can you open a bug on that as an outlier, and we'll track it separately from the rest of the world?
Depends on: 997215
(In reply to Mike Connor [:mconnor] from comment #10)
> Japan is weird, I don't think they even support SSL at present.  Can you
> open a bug on that as an outlier, and we'll track it separately from the
> rest of the world?

Filed bug 997215
Waiting for confirmation, but apparently the fix was broken (bug 997402), another piece to fix.
Mike, some more questions.

1) zh-TW has a completely different search URL
http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/a74242573f4b/browser/searchplugins/yahoo-zh-TW.xml

Should it switch to the standard one?

2) Comment above (bug 997402). That involves only mobile, correct?

3) I see you didn't update Metro searchplugins for Yahoo, I guess I should do the same.
Flags: needinfo?(mconnor)
(In reply to Francesco Lodolo [:flod] from comment #13)
> Mike, some more questions.
> 
> 1) zh-TW has a completely different search URL
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/a74242573f4b/
> browser/searchplugins/yahoo-zh-TW.xml
> 
> Should it switch to the standard one?

Yes.

> 2) Comment above (bug 997402). That involves only mobile, correct?

Yes, mobile-only.

> 3) I see you didn't update Metro searchplugins for Yahoo, I guess I should
> do the same.

No point, it's on the shelf, likely permanently.
Flags: needinfo?(mconnor)
Summary: [tracking] Update Yahoo to use SSL, implement suggestions and add resultdomain → [tracking] Update Yahoo to use SSL (searchplugins, handlers), implement suggestions (all) and add resultdomain (desktop)
One more change for mobile: bug 1001566.
Note: I'll report only the aurora changeset, but all changes will be ported to l10n-central as well if the repo is available (merge, or transplant where merge fails).

ach: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ach/rev/283872bec886
af: http://hg.mozilla.org/releases/l10n/mozilla-aurora/af/rev/c1da7644fd3c
ak: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ak/rev/cd03dd65044c
an:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/8e58750ea876
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/d1b78c06a54b
ar: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/bfcd8c063271
as: missed localized Yahoo in the first round
http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/987adec41665
http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/010c3299ba23
ast: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ast/rev/a4c330f86e9c
az: http://hg.mozilla.org/releases/l10n/mozilla-aurora/az/rev/0639ac5787c2
be: http://hg.mozilla.org/releases/l10n/mozilla-aurora/be/rev/d1dd96ca208c
bg: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bg/rev/b9b26b22d817
bn-BD: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-BD/rev/9d2416245872
bn-IN: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/afe81d4e6aaf
br: missed differences in name/description for yahoo-france
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/cb2ab88368de
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/ae7204b8b676
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/82a104aae584
bs: http://hg.mozilla.org/releases/l10n/mozilla-aurora/bs/rev/fc07e8ac02b9
ca: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ca/rev/26ca90a6f529
cs: http://hg.mozilla.org/releases/l10n/mozilla-aurora/cs/rev/a14d1ca7b718
csb: http://hg.mozilla.org/releases/l10n/mozilla-aurora/csb/rev/a2b7746763fc
cy: http://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/rev/30199273bbfb
(In reply to Francesco Lodolo [:flod] from comment #24)
> @mconnor
> Can you tell me something about Yahoo Bid and Yahoo Answer for zh-TW? They
> should come from bug 418273
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/file/154b1d126ec5/
> browser/searchplugins
> 
> Yahoo Answer has a very weird URL (updated in bug 445093)
> http://tw.rd.yahoo.com/referurl/knowledge/fp/header/search_button/*http://tw.
> knowledge.yahoo.com/search/search_result
> 
> Yahoo Bid 
> https://tw.search.bid.yahoo.com/
> I translated the page online and it seems gone. CCing also Peter who may
> have more information on that page.

That searchplugins are older than I joined. Let me ask former locale owners. 

For Yahoo! Bid, the search URL looks still working, e.g., https://tw.search.bid.yahoo.com/search/ac?p=Mozilla. Homepage for Yahoo Bid TW is https://tw.bid.yahoo.com/ though.
(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #25)
> For Yahoo! Bid, the search URL looks still working, e.g.,
> https://tw.search.bid.yahoo.com/search/ac?p=Mozilla. Homepage for Yahoo Bid
> TW is https://tw.bid.yahoo.com/ though.

Right, I tested https://tw.search.bid.yahoo.com/search/ac and got a blank page, then the message on the root. 

In this case I think it's safe to switch it the template to https (https://tw.search.bid.yahoo.com/search/ac) but the searchform should probably be https://tw.search.bid.yahoo.com (currently http://tw.search.bid.yahoo.com/search/ac)
(In reply to Francesco Lodolo [:flod] from comment #26)
> (In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #25)
> > For Yahoo! Bid, the search URL looks still working, e.g.,
> > https://tw.search.bid.yahoo.com/search/ac?p=Mozilla. Homepage for Yahoo Bid
> > TW is https://tw.bid.yahoo.com/ though.
> 
> Right, I tested https://tw.search.bid.yahoo.com/search/ac and got a blank
> page, then the message on the root. 
> 
> In this case I think it's safe to switch it the template to https
> (https://tw.search.bid.yahoo.com/search/ac) but the searchform should
> probably be https://tw.search.bid.yahoo.com (currently
> http://tw.search.bid.yahoo.com/search/ac)

The texts shown on https://tw.search.bid.yahoo.com/ says it's a 404 page, would it be strange that a 404 page is search form?

I couldn't find the original search form, only got the search box on the homepage (https://tw.bid.yahoo.com/) or advanced search (https://tw.bid.yahoo.com/tw/show/searchoptions)
(In reply to Peter Pin-Guang Chen [:petercpg] (MozTW.org) from comment #27)
> The texts shown on https://tw.search.bid.yahoo.com/ says it's a 404 page,
> would it be strange that a 404 page is search form?

Not sure how much we actually use that value, but an error page is definitely not good.

In comment 26, what I meant to write was: searchform should be https://tw.bid.yahoo.com/ (i.e. the working URL).
Based on my scripts, I only need to fix zh-TW remaining searchplugins and Japanese in the separate bug.
http://l10n.mozilla-community.org/~flod/p12n/bug994248_ssl/

Filing another bug for fy-NL (search.order).
Depends on: 1007159
Depends on: 1008206
Depends on: 1008223
I assume we're done here now?
See comment 24 for zh-TW (Yahoo properties). If we don't need to fix those, we're done (the Japanese bug will remain open).
Considering this one fixed, as said Japanese will remain open.

I guess other searchplugins will be considered in a wider check for SSL at some point, if we decide to enforce that.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(mconnor)
Resolution: --- → FIXED
Verified fixed on Windows 7 64bit using latest Nightly 44.0a1 (buildID: 20151007030205) on the following localizations: ar, ast, de, en-GB, eo, es, es-CL, es-ES, es-MX, fa, fr, fy-ML, gl, he, id, it, lv, pt-BR, th, zh-TW.
You need to log in before you can comment on or make changes to this bug.