Closed Bug 994141 Opened 6 years ago Closed 6 years ago

update localized Yahoo plugins to use SSL

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: mconnor, Assigned: flod)

Details

bug 958883 did this for en-US.  Same URLs, with the correct international domain, should work.  Please let me know if that's not true.  While we're there, we should verify that the correct partner codes are in use across all locales.
(In reply to Mike Connor [:mconnor] from comment #0)
> Please let me know if that's not true.  While we're
> there, we should verify that the correct partner codes are in use across all
> locales.

Can you clarify the parameters I should look for?

I see the suggestion template changed as well
http://hg.mozilla.org/mozilla-central/rev/97f2e9782e1c

But I don't think we have locales using it (IIRC suggestions are returned for English).

(I'm also waiting for an answer from bug 991543).
Assuming Yahoo is in the top 2:

Desktop:

moz35 (using this syntax:
<MozParam name="fr" condition="pref" pref="yahoo-fr" />)

Mobile:

<MozParam name="fr" value="mozilla_mobile_search" />

If Yahoo is included but not in the top 2, please let me know so we can discuss.

Suggestions should be localized, to the best of my knowledge.  If there are locales that don't work, please let me know.  Correct syntax is the same as US, with search.yahoo.com replaced by the appropriate internationalized domain ( https://it.search.yahoo.com/sugg/ff?command=test&appid=ffd&output=fxjson sure looks like Italian to me!)
Yes, that's Italian, but the previous URL didn't have that possibility
http://ff.search.yahoo.com/gossip?output=fxjson&command=test

Good to know that we can have localized suggestions now.

> If Yahoo is included but not in the top 2, please let me know so we can
> discuss.

See for example the ongoing discussion on Belarusian (bug 521981). We agreed to ship Yahoo and Bing with the locale, but he would like to not have them on top of others since they're not localized.

I'll have to run a script on the files to understand if we have other cases.

What's the ideal version target for these changes? I've seen the change landing only on central so far for en-US.
Results from script.

Desktop
fy-NL is shipping Yahoo, but has Google 1st, Bing 2nd

Mobile
fa, fi, id, ja, ja-JP-mac include Yahoo but only have Google as 1st
List of locales with localized versions of Yahoo

desktop: ach, af, ak, ar, az, be, bn-BD, bs, el, eo, eu, fa, he, hr, hy-AM, is, ka, km, ku, lg, lv, mk, ms, my, ro, rw, si, sq, sw, th, tn, ur, wo, zu.

mobile: de, en-GB, es-ES, fa, fi, fr, ja, ja-JP-mac, pt-BR.
Okay, so... current Yahoo deal requires top 2 placement.  I'd propose that we put Yahoo in second spot where it's otherwise unspecified, and talk to fy-NL about their ordering.  Thoughts?
(In reply to Mike Connor [:mconnor] from comment #6)
> Okay, so... current Yahoo deal requires top 2 placement.  I'd propose that
> we put Yahoo in second spot where it's otherwise unspecified, and talk to
> fy-NL about their ordering.  Thoughts?

Mike, we've been going over this with Joanne. In our last email exchange, she stated that order doesn't matter on Fennec. Flagging her to clarify.
Flags: needinfo?(jnagel)
That is correct, order is specific to desktop only.  In the future, please send email so we do not discuss contract terms in public bugs.
Flags: needinfo?(jnagel)
Group: mozilla-employee-confidential
Component: Other → Search
Product: Mozilla Localizations → Firefox
Moving to Firefox-Search and marking as mo-co confidential, I'll file another tracking bug to actually update Yahoo searchplugins.

We have a meeting scheduled for this Friday, can we discuss this in that meeting?

Still open question: what's the target version of this?
No longer blocks: 958883
Note that I'm also a bit confused. Just a few cycles ago we had to changes like this one
https://bugzilla.mozilla.org/show_bug.cgi?id=931112

Where Yahoo has conditions like this

>  <MozParam name="fr" condition="top2" trueValue="mozilla_mobile_search" falseValue="" />

Filed bug 994248 for tracking actual changes.
Let's close this one and work in the other bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
I don't think anything in this bug is confidential.
Group: mozilla-employee-confidential
You need to log in before you can comment on or make changes to this bug.