Closed Bug 991640 Opened 6 years ago Closed 6 years ago
Get rid of ns
IWidget::Get Thebes Surface and a bunch of Thebes backed gfx Contexts
We should Moz2Dify nsIWidget::GetThebesSurface to get rid of a bunch of Thebes backed gfxContexts.
It's only widget/gtk/nsWindow.cpp, widget/windows/nsWindow.cpp and widget/xpwidgets/PuppetWidget.h that need finished off here.
It appears that the *only* caller of this function is inFlasher.cpp, and that appears to be dead code. It can't even work for a lot of platforms where we have hardware acceleration anyway. I think if we kill that then everything can go, except for a private function for gtk/nsWindow.
Summary: Moz2Dify nsIWidget::GetThebesSurface and get rid of a bunch of Thebes backed gfxContexts → Get rid of nsIWidget::GetThebesSurface and a bunch of Thebes backed gfxContexts
I'll do widget/gtk/nsWindow.cpp separately. I'd like to get this landed so I don't have to unbitrot it again.
Actually the DT must be cached and reused in PuppetWidget or else we get various timeouts in tests for some reason: https://tbpl.mozilla.org/?tree=Try&rev=6beaf6199419
Attachment #8432099 - Flags: review?(matt.woodrow) → review+
(In reply to Jonathan Watt [:jwatt] from comment #5) > Actually the DT must be cached and reused in PuppetWidget or else we get > various timeouts in tests for some reason: > > https://tbpl.mozilla.org/?tree=Try&rev=6beaf6199419 That's very weird. I'd have thought that path was dead code.
(In reply to Matt Woodrow (:mattwoodrow) from comment #3) > It appears that the *only* caller of this function is inFlasher.cpp, and > that appears to be dead code. You can exercise that code with the DOM inspector addon: https://addons.mozilla.org/en-US/firefox/addon/dom-inspector-6622/
Yes, see bug 1018324, which blocks this bug.
Plus follow-up for Linux warning-is-error: https://hg.mozilla.org/integration/mozilla-inbound/rev/a4859b482f44
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.