992915 - [Emergency-call] Emergency call main dialer screen (keypad) visual refresh 2.0

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Anthony Ricaud (:rik)]

It would be nice that as part of this work, we can share some code between Dialer and emergency app. Maybe through shared elements?

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Hi Anthony, is this bug a duplicate of bug 993951 or is it meant to cover something beyond the visual refresh itself? Thanks!

Comment 2

[Anthony Ricaud (:rik)]

The emergency-call app is the one displayed when you have a lock screen with password and you tap "emergency call". So this is not a duplicate.

Comment 3

[Victoria Gerchinhoren [:vicky]]

Yeap, it is a duplicate... we're talking about the same, right Noemi?

Comment 4

[Noemí Freire (:noemi)]

(In reply to Victoria Gerchinhoren [:vicky] on PTO 14 - 16 and holidays 18 - 21 Apr included. from comment #3)
> Yeap, it is a duplicate... we're talking about the same, right Noemi?

I think Anthony is referring to the specific dialer view (please see 2014-04-22-step2.png screenshot attached) that appears when tapping on Emergency call button in lock screen + passcode lock (please see 2014-04-22-step1.png screenshot attached). so it would be a different screen.

Comment 5

[Noemí Freire (:noemi)]

Attachment: 2014-04-22-step1.png

Comment 6

[Noemí Freire (:noemi)]

Attachment: 2014-04-22-step2.png

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

To avoid confusion, this bug will deal with the dialpad shown to make emergency calls whereas bug 993951 will deal with the particularities of the "call screen" in the case of an emergency call :-)

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

On which case we need specs for the visual refresh of attachment 8410257 [details] :-) Mostly regarding the "Cancel" button since the rest I guess will be equal to the "normal dial pad" except from not showing the voicemail icon.

Comment 9

[Victoria Gerchinhoren [:vicky]]

Attaching the visuals for this implementation. The only change should be the "Cancel" button and the absence of the voicemail icon next to Nbr 1.

Comment 10

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup: Emergency call dialer screen

Comment 11

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Spec: Dialer emergecncy call

Comment 12

[Anthony Ricaud (:rik)]

Quick note: We won't use the tab bar from Dialer. We are in a lockscreen state so we don't want to access call history or contacts.

Comment 13

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Dailer. EmergencyCall

Visual Mockup of Dialer's Emergency call screen

Comment 14

[Pau Masiá [:Pau]]

Attachment: Visual Spec. Expandable Areas. Dialer. Emergency call

Visual spec of Dialer's Emergency call screen pointing out what areas are expandable or not.

Comment 15

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Spec. Expandable Areas. Dialer. Emergency call (N)

Comment 16

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup. Dailer. EmergencyCall (N)

Comment 17

[Victoria Gerchinhoren [:vicky]]

Due to the contrast ratio issue, colors have been adjusted. Please refer to the updated mockups and specs recently attached.

Please change the colors and replace icons and ask for UI review again

Comment 18

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 19

[Paco Rampas [:paco]]

Attachment: cancel active.png

Comment 20

[Paco Rampas [:paco]]

Attachment: idle.png

Comment 21

[Paco Rampas [:paco]]

Attachment: with numbers.png

Comment 22

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8419364 [details]
with numbers.png

Numbers written in the upper part of the screen are too small respect to the proposed design. Please use the specified size in the main dialer screen. Thanks!

Comment 23

[Paco Rampas [:paco]]

I have uploaded the patch in github, could you see it?

Also, could you see how to use big numbers on the keypad input?
https://bug992915.bugzilla.mozilla.org/attachment.cgi?id=8419364
It is set by keypad.js. I tryed to change app/emergency-call/js/keypad.js by shared/dialer/js/keypad.js but dosen't work.
Thanks.

Comment 24

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! We can deal with the maximum and minimum font size in the Dialer and Emergency Call apps in bug 1007747. I'll update the title of the bug and block this one by bug 1007747 ;-)

It seems I cannot set this bug as blocked by bug 1007747 because we would create a circular flow of dependencies :-D but I'll push it forward and coordinate this work with Paco ;-)

Comment 25

[Etienne Segonzac (:etienne)]

Comment on attachment 8419350 [details] [review]
patch in github

This patch is good, you can go ahead once the 2 now unused css files are remove (see github).

For the fontsize ideally we would re-unify emergency-call/js/keypad.js and shared/js/dialer/keypad.js, but it's outside of the scope for this bug.

Comment 26

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 89fd95d1c0599e6f6c419bc2b243f5b26b8778fe

Comment 27

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: emergency-call-wron-layout.png

The layout is wrong on today's master. Here is the screenshot.

Git version:

2014-05-22 07:58:51
da4c2e0a

Comment 28

[Greg Weng [:snowmantw][:gweng][:λ]]

NI to confirm it. Maybe something is wrong with my device (Buri), or it really got the wrong layout.

Comment 29

[Paco Rampas [:paco]]

Thanks for alerting of the issue.
We are going to fix it ;)

Comment 30

[Anthony Ricaud (:rik)]

My bad, I'll fix it in bug 995128.

Comment 31

[Loli (:lolimartinezcr)]

Related with this development, I have created this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1014515

Comment 32

[Loli (:lolimartinezcr)]

 Tested and working
Hamachi
2.0
Gecko-3e5340d
Gaia-7416a20