Closed Bug 993951 Opened 6 years ago Closed 5 years ago

[Dialer] Emergency call screen visual refresh 2.0

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 fixed)

VERIFIED FIXED
2.0 S3 (6june)
feature-b2g 2.0
tracking-b2g backlog
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: noemi, Assigned: gtorodelvalle)

References

Details

(Whiteboard: ux-tracking, visual design, visual-tracking, bokken, [p=3])

Attachments

(7 files, 1 obsolete file)

Apply new Emergency call screen design

Attaching the current one "Current_Emergency_Call_UI.png". ni to visual team to provide the new one
Flags: needinfo?(vpg)
Whiteboard: ux-tracking, visual design, visual-tracking, bokken
Assignee: nobody → joshua-smith
UX spec please :)
Hi Joshua, Paco, Pablo and myself are currently working on the visual refresh of the Dialer (see bug 951604, 951606, 951665, 985909 and 985944). Would you be fine with us taking care of this bug? We have already made some progress on it :-) If you are fine with it I'll assign it to myself. Thanks!
Flags: needinfo?(joshua-smith)
Sure, happy hacking!
Assignee: joshua-smith → gtorodelvalle
Flags: needinfo?(joshua-smith)
Specs to match visual design
Pau will provide the visual mockup and spec for the imaplementation of this screen. Remember that this screen should show the user's background as the call background as there are no generic image for this version. In the future an "emergency backgrpund" must be needed.

NI Sabrina regarding this.
Flags: needinfo?(vpg) → needinfo?(ssmelko)
Whiteboard: ux-tracking, visual design, visual-tracking, bokken → ux-tracking, visual design, visual-tracking, bokken, [p=3]
Target Milestone: --- → 2.0 S1 (9may)
QA Contact: lolimartinezcr
The VDR mockup looks great to me, perhaps worth notifying Przemek re: the look of the controls.
Flags: needinfo?(ssmelko) → needinfo?(pabratowski)
Hey, I think I may have misunderstood the request. Vicky, can you clarify what were you looking for me to help with? Was it the default/background image? :) Let me know, thanks and sorry for the confusion.
Flags: needinfo?(pabratowski)
Flags: needinfo?(vpg)
Summary: [Dialer] Emergency call screen visual refresh 1.5 → [Dialer] Emergency call screen visual refresh 2.0
(In reply to Sabrina Smelko from comment #8)
> Hey, I think I may have misunderstood the request. Vicky, can you clarify
> what were you looking for me to help with? Was it the default/background
> image? :) Let me know, thanks and sorry for the confusion.

Will clarify offline, you don't need to provide info here, as it would be a 2.1 issue.

Thanks.
Flags: needinfo?(vpg)
Target Milestone: 2.0 S1 (9may) → 2.0 S2 (23may)
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
Depends on: 951606
Attachment #8425427 - Flags: ui-review?(vpg)
Attached image emergencycall_ended.png (obsolete) —
Hi Vicky, this is the appearance of the emergency call when ended. I guess this is not what you expected but there's no spec or visual about this case as far as I know. Could you tell me how it should look like, please? Thanks!
Attachment #8425431 - Flags: ui-review?(vpg)
Hi Vicky! Do you want us to highlight somehow the fact that this is an emergency call?

I need also the appearance when the call is hung up when a red background (rgba(107, 0, 0, 0.9)) is set to the status bar. Thanks!
Attachment #8425435 - Flags: ui-review?(vpg)
Attachment #8425427 - Flags: ui-review?(vpg) → ui-review+
Comment on attachment 8425431 [details]
emergencycall_ended.png

Please put the number in the same color/opacity as the "emergency number" label.
Attachment #8425431 - Flags: ui-review?(vpg) → ui-review-
Comment on attachment 8425435 [details]
emergencycall_ongoing_statusbar.png

hmmm.
Attachment #8425435 - Flags: ui-review?(vpg) → ui-review+
Attached image emergencycall_ended.png
Attachment #8425431 - Attachment is obsolete: true
Attachment #8425458 - Flags: ui-review?(vpg)
Attachment #8425458 - Flags: ui-review?(vpg) → ui-review+
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Attached file 19927.html
Attachment #8433203 - Flags: review?(anthony)
Comment on attachment 8433203 [details]
19927.html

Taking the review
Attachment #8433203 - Flags: review?(anthony) → review?(etienne)
Comment on attachment 8433203 [details]
19927.html

Comments on github, it should be a pretty quick follow up.
Thanks!
Attachment #8433203 - Flags: review?(etienne)
Comment on attachment 8433203 [details]
19927.html

Comments commented :p Please, have a look at them in https://github.com/mozilla-b2g/gaia/pull/19927 and tell me please if you are OK with them ;) Thanks!!
Attachment #8433203 - Flags: review?(etienne)
Comment on attachment 8433203 [details]
19927.html

r=me with a comment explaining why we keep the dead |setEmergencyWallpaper| and a link to the bug
Attachment #8433203 - Flags: review?(etienne) → review+
https://github.com/mozilla-b2g/gaia/commit/089d170f986d2916e3551935c74bf4c865f45cfd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Thanks Etienne for merging! ;)
Tested and working
Hamachi
2.1
Gecko-a777777
Gaia-049853b
Status: RESOLVED → VERIFIED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.