993197 - Asynchronize nsILoginManager::autoCompleteSearch

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

For bug 949617, we need to be able to asynchronously fill in logins for nsLoginManager-managed login fields. Currently, the code expects that to be a synchronous action, which is less than ideal.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch v1

One thing that I know I'm not doing is calling StopAutoCompleteSearch on the login manager when we call nsFormFillController::StopSearch. Is that important?

https://tbpl.mozilla.org/?tree=Try&rev=4df854c3e162

Comment 2

[Chris Peterson [:cpeterson]]

Mass tracking-e10s flag change. Filter bugmail on "2be0fcce-e36a-4e2c-aa80-0e3d33eb5406".

Comment 4

[Justin Dolske [:Dolske]]

Comment on attachment 8403025 [details] [diff] [review]
Patch v1

Review of attachment 8403025 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/passwordmgr/nsLoginManager.js
@@ +13,5 @@
>  
>  XPCOMUtils.defineLazyModuleGetter(this,
>    "LoginManagerContent", "resource://gre/modules/LoginManagerContent.jsm");
>  
> +var debug = true;

I think you forgot to remove this.

@@ +465,5 @@
> +                // filter logins without a username, since that's confusing to see
> +                // in the dropdown and we can't autocomplete them anyway.
> +                for (let i = 0; i < logins.length; i++) {
> +                    var username = logins[i].username.toLowerCase();
> +                    log(username);

I think you forgot to remove this too.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/654c1f0c88bc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Something in this push made Android sadface. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f291b1b47c7

https://tbpl.mozilla.org/php/getParsedLog.php?id=42378026&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=42378331&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=42377296&tree=Mozilla-Inbound

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Take 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/f556e62f5ee8

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f556e62f5ee8

Comment 9

[Carsten Book [:Tomcat]]

sorry had to back this out from mozilla-central in https://tbpl.mozilla.org/?onlyunstarred=1&rev=83f9b25520bf since one of this checkins seems to have caused Bug 1030663 which is a frequent test failurew now

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc701f3d06b2

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/fc701f3d06b2