Closed
Bug 993940
Opened 11 years ago
Closed 11 years ago
backport bug 428490 to bmo (Group icons should be displayed for indirect memberships, too)
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Assigned: dylan)
Details
(Keywords: bmo-goal, perf)
Attachments
(1 file)
|
1.94 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
we should backport the removal of direct_group_membership from bug 428490, and change $user->groups_with_icon() to call $self->groups().
groups_with_icon is called for each commenter, resulting in two database calls per commenter. backporting bug 428490 puts us in the position of reaping the rewards bug 993939 will provide once fixed.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → dylan
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Trivial patch, tested locally (fun fact: the BMO dump has no group icons, so I had to add them to make sure this was working.)
Attachment #8405594 -
Flags: review?(dkl)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8405594 [details] [diff] [review]
bug-993940-v1.patch
Review of attachment 8405594 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8405594 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Commited 4769d00.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•