Closed Bug 993999 Opened 6 years ago Closed 6 years ago

[Tarako] Two async reflows (73 ms. each) when keyboard pops up

Categories

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

x86
macOS
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: janjongboom, Assigned: janjongboom)

References

Details

Attachments

(2 files)

With bug 993367, bug 993390, bug 993393, bug 993952 we still see two massive async reflows when the user focuses on a text field on Tarako.

reflow: 172.79ms
reflow: 173.86ms
Blocks: 994000
The time depends on the number of keyboards open, so minimum is like 30, and this was with 6 layouts loaded.
Component: Gaia::Keyboard → Gaia::System::Input Mgmt
Attached file Patch for master
Attachment #8403917 - Flags: review?(rlu)
The hidden attribute basically is the same as display: none. By restoring the value of display to block all the content of the element needs to be recalculated, hence the big reflow. That's not very smart, because the keyboard that was active before blur will also be active after focus, so we're reflowing for nothing. By just hiding the element off screen we can show the keyboard again without reflow.
Attached file Patch for v1.3t
Attachment #8403919 - Flags: review?(rlu)
blocking-b2g: --- → 1.3T?
Comment on attachment 8403917 [details] [review]
Patch for master

r=me.

Please help refer to the suggestions on github pull request.

Jan,

Thanks for working on this.
Attachment #8403917 - Flags: review?(rlu) → review+
Comment on attachment 8403919 [details] [review]
Patch for v1.3t

r+ with the same comments on master branch.
Thanks.
Attachment #8403919 - Flags: review?(rlu) → review+
blocking-b2g: 1.3T? → 1.3T+
Hi! Xu Ying,

Check in needed.

--
Keven
Flags: needinfo?(ying.xu)
Was that pushed only to 1.3t? If so, please don't do that. Wait for the patch to be on master, and marked as fixed before uplifting. thanks!
master: https://github.com/comoyo/gaia/commit/87053e0b8816aaec834c20522ff9f6e6df8009e9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.