Closed Bug 994527 Opened 6 years ago Closed 6 years ago

[System2][PermissionManager] window.permissionManager is undefined because PermissionManager.start doesn't return itself

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alive, Unassigned)

References

Details

Attachments

(1 file)

Comment on attachment 8404495 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18147

I don't think start() should return itself. Rather we should correct the init code in bootstrap.js
Attachment #8404495 - Flags: review?(timdream)
Attachment #8404495 - Flags: review?(timdream)
Comment on attachment 8404495 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/18147

It is appears other modules suffers the same issue...
Attachment #8404495 - Flags: review?(timdream) → review+
Let's fix in followup.
https://github.com/mozilla-b2g/gaia/commit/679dc48477f25e68fbe191e960e7c09ca3a4afdc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.