Closed Bug 994571 Opened 6 years ago Closed 5 years ago

[System2] Remove the pattern to return self in start().

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alive, Assigned: yifan)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
No description provided.
Whiteboard: [good first bug]
Assignee: nobody → yliao
Attached file pull request
Bug 994571 - [System2] Remove the pattern to return self in start()

* Remove 'var module = new Module().start()' pattern.
* Remove 'return this;' expression in start() function definitions.
Attachment #8454272 - Flags: review?(alive)
Comment on attachment 8454272 [details] [review]
pull request

r+ but I think you will need rebase.

Thank you for helping!
Attachment #8454272 - Flags: review?(alive) → review+
You need to log in before you can comment on or make changes to this bug.