Closed
Bug 994571
Opened 12 years ago
Closed 11 years ago
[System2] Remove the pattern to return self in start().
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: alive, Assigned: yifan)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
No description provided.
|
Reporter | |
Updated•11 years ago
|
Whiteboard: [good first bug]
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → yliao
|
|
Assignee | |
Comment 1•11 years ago
|
||
Bug 994571 - [System2] Remove the pattern to return self in start()
* Remove 'var module = new Module().start()' pattern.
* Remove 'return this;' expression in start() function definitions.
Attachment #8454272 -
Flags: review?(alive)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8454272 [details] [review]
pull request
r+ but I think you will need rebase.
Thank you for helping!
Attachment #8454272 -
Flags: review?(alive) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Merged in master branch
https://github.com/mozilla-b2g/gaia/commit/5dd80d8156a476e884d1572193a61f6aaf806bbe
Travis
https://travis-ci.org/mozilla-b2g/gaia/builds/30154711
TBPL
https://tbpl.mozilla.org/?rev=d5e8437e750caab3a2b0a0cc79a4e45df6052ee6&tree=Gaia-Try
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•