[System2] Instantiable PermissionManager

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alive, Assigned: gasolin@mozilla.com)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We need permission_manager.js to be instantiable and let bootstrap or its parent module to instantiate it.
Also jsdoc + unit test improvement wanted.
(Assignee)

Updated

4 years ago
Assignee: nobody → gasolin
(Assignee)

Comment 2

4 years ago
Created attachment 8397589 [details] [review]
pull request redirect to github
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Attachment #8397589 - Flags: review?(alive)
Comment on attachment 8397589 [details] [review]
pull request redirect to github

r+ with nits
Attachment #8397589 - Flags: review?(alive) → review+
(Assignee)

Comment 4

4 years ago
fix nits and merged https://github.com/mozilla-b2g/gaia/commit/4a2e2032589de749583a3674cb2a433b5a8e8361

thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

4 years ago
will revert this via https://github.com/mozilla-b2g/gaia/pull/17937 to fix gaia unit test error for quick settings > wifi test.

Will check why this effect the quick settings test...
(In reply to Fred Lin [:gasolin] from comment #5)
> will revert this via https://github.com/mozilla-b2g/gaia/pull/17937 to fix
> gaia unit test error for quick settings > wifi test.
> 
> Will check why this effect the quick settings test...

Sorry, I already beat you to it :-p Backed out: https://github.com/mozilla-b2g/gaia/commit/713c370cbbe67c082e912d947eb4c047bc2243ec

Please ensure travis is green before merging in the future. Error details:

[system] quick settings > system/quick settings/enable wifi: Connected:

Error: expected false to equal true

at chaiAssert (http://system.gaiamobile.org:8080/common/test/helper.js:33:1)

at equal (http://system.gaiamobile.org:8080/common/vendor/chai/chai.js:1250:1)

at (anonymous) (http://system.gaiamobile.org:8080/test/unit/quick_settings_test.js:79:1)

at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)

at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at runTest (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)

at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)

at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)

at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979:7)

at done (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712:9)

at (anonymous) (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:46:13)

at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:73:15)

at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)

at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)

at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

4 years ago
Same commit merged with travis green https://github.com/mozilla-b2g/gaia/commit/f1a98bfaa3ab2480945bd7018831fd56c61cdc24

thanks kevin for travis sanbox!
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
Blocks: 994527
Blocks: 994571

Updated

4 years ago
Depends on: 996264
You need to log in before you can comment on or make changes to this bug.