995938 - Device does not play an 'end tone' when the call is finished

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

EXPECTED
When the call is finished a disconnected tone must be audibly in both parts.

ACTUAL
Nothing is heard when the call is finished

This has been reported during certification process for v1.3, it would be a nice to have feature for future releases, if possible please add to backlog. Thanks

Comment 1

[Noemí Freire (:noemi)]

Adding to backlog to be properly prioritized. Thanks!

Comment 4

[Maria Angeles Oteo (:oteo)]

Telefonica wants to implement this feature as this issue is a certification waiver in all the releases.
I think it's an easy fix that will make our life easier when getting the Technical Acceptance in next releases just we need to agree with the specific tone for it, so setting ni to Wilfred (Product) and Carrie (UX) to help us to select it.

Comment 5

[Wilfred Mathanaraj [:WDM]]

carrie - as we discussed this would be one of those items we already talked abut.

Maria Angeles - we are fine with this - if there is any User facing items please send us a UX document so we can look at what is planned to be implemented.

but looking at the description i dont think there is any user facing items than a tone. Perhaps we can identify the tone that needs to be played?

Comment 6

[Maria Angeles Oteo (:oteo)]

(In reply to Wilfred Mathanaraj [:WDM] from comment #5)
> 
> but looking at the description i dont think there is any user facing items
> than a tone. Perhaps we can identify the tone that needs to be played?

yeah, that is what we need, confirm the tone to be used. Do you want us to propose one or should we wait for your feedback?

Comment 7

[Wilfred Mathanaraj [:WDM]]

propose and we can work on it - i expect not a lengthy tune for 30 seconds

Comment 8

[Juanjo Iglesias]

I have tested it using a Unagi master (today build 14th July, gecko f6aad75 and gaia 108dab2) and the SMSC is displayed properly (picture attached).

Comment 9

[Juanjo Iglesias]

Sorry, this comment is for other bug...  i´m so sorry

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! We are currently investigating in the solution used in Android. In fact, it seems it consists on playing an ogg tone (we are currently looking for) located in /system/media/audio/ui

We'll keep you posted ;)

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Hi again! Since according to Mother Wikipedia :O http://en.wikipedia.org/wiki/Disconnect_tone (I also found it on a more 'official' document: page 2 of http://www.unetel.com.mx/Micronet/download/Tool/VoIP/Disconnect_Tone_Configuration.pdf) and we currently have support for the busy tone (see https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/telephony_helper.js#L55) I would suggest using the first tone of the busy tone to notify the ending of the call. You can play it at http://en.wikipedia.org/wiki/Busy_signal As I said, we would only play the first tone to distinguish it of the busy tone. What do you think, Beatriz, Mari Ángeles?

Comment 12

[Maria Angeles Oteo (:oteo)]

For me, it's fine, thanks a lot German!

Comment 13

[Beatriz Rodríguez [:brg]]

It is ok for me! Thanks Germán!

Comment 14

[Maria Angeles Oteo (:oteo)]

Carrie, Wilfred, do you agree with the proposal included by German in comment 11? Let's know, please

Comment 15

[Germán Toro del Valle (:gtorodelvalle)]

BTW, I just created bug 1010104 which could affect the patch for this bug. How do you feel like taking it, David, to get in touch with the tone playing functionality? :)

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

Ups, sorry!!! Bad copy&pasting :( The related bug is bug 1038616 :)

Comment 17

[David Garcia [:davidg][retired]]

Sure! I think both are pretty related so I will take a look at both.

The problem I'm observing is that TonePlayer.playSequence wasn't working for me unless I do first TonePlayer.setChannel('telephony'). 
I looked for TonePlayer.init or TonePlayer.setChannel in the callscreen application in the callscreen app, but couldn't find any, so I don't know how TonePlayer knows what channel to use.

It seems to me, that all the tones played by the callscreen should be part of the 'telephony' audio channel, as they should be in some part of the call.

My proposal it to call TonePlayer.setChannel('telephony') at the beginning of the callscreen app.

Etienne, do you think that makes sense? What channel should we use for the tones?

Comment 18

[David Garcia [:davidg][retired]]

I just discovered that keypad.js is setting TonePlayer channel to "normal" every time it gets visible.
Because all the app code shares the same instance of TonePlayer, you would probably need to call setChannel before playing any tone, just to be sure you are playing in the right channel. 
I think it should work, but it is a bit messy.

In my opinion, a better solution would be to make TonePlayer a regular class instead of a singleton, so keypad and callscreen each have their own instance.

Comment 19

[Etienne Segonzac (:etienne)]

> In my opinion, a better solution would be to make TonePlayer a regular class
> instead of a singleton, so keypad and callscreen each have their own
> instance.

The callscreen is a separate app so those are 2 different singletons :)
Like I said on bug 1038616, makes sense to play this on the telephony channel, but we need to go back to the normal channel afterward.

Comment 20

[David Garcia [:davidg][retired]]

Attachment: github PR

Comment 21

[David Garcia [:davidg][retired]]

Both shared/js/dialer/keypad.js and apps/callscreen/js/calls_handler.js, are included in the callscreen app, so both share the same TonePlayer instance.
What I did at the end is; get the current channel, switch to telephony channel, play the sound and then restore the previous channel.
Does that makes sense? 

Thanks Etienne!

Comment 22

[Etienne Segonzac (:etienne)]

Comment on attachment 8456162 [details] [review]
github PR

My bad I thought you were playing the tone from the Dialer app.

The TonePlayer should always be on the telephony channel in the callscreen app (excepts when we switch to normal before trashing it).
If not that's a bug we need to fix as part of this patch.

Comment 23

[Carrie Wang [New account: [e-mail]]]

Since this is something related to sound, I think Patryk is in charge of this and he should be aware of the change and confirm it. ni?Patryk

Comment 24

[David Garcia [:davidg][retired]]

Attachment: github PR v 2

Comment 25

[Etienne Segonzac (:etienne)]

Comment on attachment 8458027 [details] [review]
github PR v 2

Small comment on github, but the main issue is that we need more tests :)

Also I'd like to confirm that we want this sound to play of all calls (even in multiple calls/conference group scenario) and not just the last disconnected call.

Comment 26

[David Garcia [:davidg][retired]]

Sorted the comment from Etienne and added some tests.
Putting this on hold until we get confirmation on:
- The tone we are playing is ok.
- What should be the behavior for multiple calls/conference groups.

Comment 27

[Patryk Adamczyk [:patryk] UX]

What tone are you using for the "end call"?

Comment 28

[Maria Angeles Oteo (:oteo)]

(In reply to Patryk Adamczyk [:patryk] UX from comment #27)
> What tone are you using for the "end call"?

Patrick, check comment 11, please
"You can play it at http://en.wikipedia.org/wiki/Busy_signal As I said, we would only play the first tone to distinguish it of the busy tone"
Thanks!

Comment 29

[Patryk Adamczyk [:patryk] UX]

So do you have a tone you can use? Or does one need to be created?

Comment 30

[Maria Angeles Oteo (:oteo)]

(In reply to Patryk Adamczyk [:patryk] UX from comment #29)
> So do you have a tone you can use? Or does one need to be created?

Yes, we already have it, you can play it here http://en.wikipedia.org/wiki/Busy_signal but we would only play the first tone (just one beep)

For Telefonica, it's fine and we have it already in the Dialer and included in the patch but we need Mozilla to confirm if it's ok with it. That's the reason Carrie wants you to confirm you are also happy with it. Nothing else is required :) If you say ok, we can land it

Comment 31

[Patryk Adamczyk [:patryk] UX]

Oh ok. Its fine, please land it!

Comment 32

[David Garcia [:davidg][retired]]

With the proposed patch, in multiple calls/conference group scenario, the tone is played every time someone hangs up. It sounds reasonable to me. 
Is everybody happy with it?

Comment 33

[Maria Angeles Oteo (:oteo)]

Yes, you are right, although in the certification tests there is not a specific test to check this I agree with Etienne that it should sound when each participant leaves the conference and with the same "end call" tone. I've checked in different devices (as I-phone) and it's implemented in this way.

Anyway, setting ni to Carrie to confirm this is the expected behavior.

Comment 34

[Carrie Wang [New account: [e-mail]]]

Yes, I'm fine with it. Thanks!

Comment 35

[David Garcia [:davidg][retired]]

Comment on attachment 8458027 [details] [review]
github PR v 2

Final review from Etienne. Thanks!

Comment 36

[Etienne Segonzac (:etienne)]

Comment on attachment 8458027 [details] [review]
github PR v 2

r=me
(small nit on github)

Comment 37

[David Garcia [:davidg][retired]]

Master: 56d0b6b2baa3dab7670b9c78e8a1a7b5e80591c3

Comment 38

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko-46c9b03
Gaia-80a452a

Comment 39

[Sue]

Attachment: verify_video.MP4

This issue has been verified successfully on Flame v2.1
STR:
1. Made a call to another device.
2. Hang up the call.
**When the call is finished a disconnected tone will be audibly in both parts.
See attachment: verify_video.MP4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880