Closed
Bug 995989
Opened 10 years ago
Closed 10 years ago
Actions(self.marionette).flick() has stopped working in the Calendar and FMRadio apps
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(b2g-v1.4 fixed)
RESOLVED
FIXED
mozilla32
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
People
(Reporter: AndreiH, Assigned: mdas)
References
Details
(Keywords: pi-marionette-userinput, regression, Whiteboard: [xfail])
Attachments
(1 file)
770 bytes,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
Test test_calendar_flick_through_months.TestCalendar is failing on Jenkins and this can also be seen locally. Tested this manually and it does not reproduce. Traceback (most recent call last): 06:20:12 File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run 06:20:12 testMethod() 06:20:12 File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/tests/functional/calendar/test_calendar_flick_through_months.py", line 28, in test_calendar_flick_through_months 06:20:12 calendar.flick_to_next_month() 06:20:12 File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/apps/calendar/app.py", line 90, in flick_to_next_month 06:20:12 self._flick_to_month('next') 06:20:12 File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/apps/calendar/app.py", line 114, in _flick_to_month 06:20:12 lambda m: self.current_month_year != month_year) 06:20:12 File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 54, in wait_for_condition 06:20:12 Wait(self.marionette, timeout).until(method, message=message) 06:20:12 File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until 06:20:12 cause=last_exc) 06:20:12 TimeoutException: TimeoutException: Timed out after 30.0357811451 seconds 06:20:12 TEST-UNEXPECTED-FAIL | test_calendar_flick_through_months.py test_calendar_flick_through_months.TestCalendar.test_calendar_flick_through_months | 06:20:12 ---------------------------------------------------------------------- 06:20:12 Ran 1 test in 83.701s
Assignee | ||
Comment 1•10 years ago
|
||
Seems like it's fallout from https://bugzilla.mozilla.org/show_bug.cgi?id=958036. I've run this test with the changes in this patch reverted, and the test passes. My hypothesis is that we shouldn't dispatch injectTouchEvent calls unless we know we are triggering a scroll... if this is the case, it may be difficult to solve. I'll set some time to investigate this problem this week.
Assignee: nobody → mdas
Component: Gaia::UI Tests → Marionette
Product: Firefox OS → Testing
Assignee | ||
Comment 2•10 years ago
|
||
I'm having trouble re-running the test. When I run the test after flashing, it runs fine, but if I rerun it, I get: TEST-START test_calendar_flick_through_months.py test_calendar_flick_through_months (test_calendar_flick_through_months.TestCalendar) https://bugzilla.mozilla.org/show_bug.cgi?id=937085 ... ERROR ====================================================================== ERROR: None ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/mdas/Code/gaia/tests/python/gaia-ui-tests/venv/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run testMethod() File "/Users/mdas/Code/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/calendar/test_calendar_flick_through_months.py", line 26, in test_calendar_flick_through_months calendar.launch() File "/Users/mdas/Code/gaia/tests/python/gaia-ui-tests/gaiatest/apps/calendar/app.py", line 27, in launch self.wait_for_element_displayed(*self._hint_swipe_to_navigate_locator) File "/Users/mdas/Code/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 42, in wait_for_element_displayed lambda m: m.find_element(by, locator).is_displayed()) File "/Users/mdas/Code/gaia/tests/python/gaia-ui-tests/venv/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until cause=last_exc) TimeoutException: TimeoutException: Timed out after 30.1092219353 seconds TEST-UNEXPECTED-FAIL | test_calendar_flick_through_months.py test_calendar_flick_through_months.TestCalendar.test_calendar_flick_through_months | ---------------------------------------------------------------------- Ran 1 test in 51.980s FAILED (errors=1) Do you know why?
Flags: needinfo?(andrei.hutusoru)
Keywords: ateam-marionette-userinput
Assignee | ||
Comment 3•10 years ago
|
||
this bug may also be causing https://bugzilla.mozilla.org/show_bug.cgi?id=995990. Will need to investigate
Comment 4•10 years ago
|
||
Re comment #2, you will have to run this with --restart as it's expecting a UI element that's only present with a fresh profile. Or you can just temporarily replace that line with a short sleep.
Flags: needinfo?(andrei.hutusoru)
Comment 5•10 years ago
|
||
Renaming this as 2 apps are affected by the same issue
Summary: Fix test_calendar_flick_through_months.TestCalendar → Actions(self.marionette).flick() has stopped working in the Calendar and FMRadio apps
Updated•10 years ago
|
Whiteboard: [xfail]
Updated•10 years ago
|
Keywords: regression
Assignee | ||
Comment 7•10 years ago
|
||
I wanted to get around to this this week but was sidetracked by an urgent request. I'm upping this to critical so I can get around to it next week.
Severity: normal → critical
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Comment 8•10 years ago
|
||
We were creating a new touch event identifier when we should have been using the one the Touch object actually refers to. Not sure how this worked before, but this fixes this problem, and doesn't cause a regression from the original problem (https://bugzilla.mozilla.org/show_bug.cgi?id=958036)
Attachment #8414733 -
Flags: review?(dburns)
Assignee | ||
Comment 9•10 years ago
|
||
try for Gu: https://tbpl.mozilla.org/?tree=Try&rev=e167de70d293 try for marionette: https://tbpl.mozilla.org/?tree=Try&rev=f349ae4ef99d
Assignee | ||
Comment 10•10 years ago
|
||
grumble, grumble... debug instead of opt... grumble: Mn tests: https://tbpl.mozilla.org/?tree=Try&rev=5d01e6331b87
Updated•10 years ago
|
Attachment #8414733 -
Flags: review?(dburns) → review+
Assignee | ||
Comment 11•10 years ago
|
||
landed on mi: https://hg.mozilla.org/integration/mozilla-inbound/rev/c37e8f0d74d1
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c37e8f0d74d1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Assignee | ||
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
Assignee | ||
Comment 13•10 years ago
|
||
This needs to be uplifted to 2.0. Will get on that later today
Assignee | ||
Comment 14•10 years ago
|
||
(In reply to Malini Das [:mdas] from comment #13) > This needs to be uplifted to 2.0. Will get on that later today whoops, wrong bug.
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•