Closed
Bug 996768
Opened 11 years ago
Closed 11 years ago
ContainerLayer{D3D10,Composite}.cpp don't play nicely with unified builds
Categories
(Core :: Graphics: Layers, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
|
4.63 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
While trying to implement bug 995411 my try push failed on Win XP (Debug and Opt). Turns out both ContainerLayerD3D10.cpp and ContainerLayerComposite.cpp have a function called HasOpaqueAncestorLayer and if both files get put into the same unified build compilation module then the compiler doesn't like it.
|
Assignee | |
Comment 1•11 years ago
|
||
Included in try push at https://tbpl.mozilla.org/?tree=Try&rev=0160269505d9
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8407039 [details] [diff] [review]
Tentative patch
Pretty small patch, removing duplicated code.
Attachment #8407039 -
Flags: review?(bas)
|
||
Updated•11 years ago
|
Attachment #8407039 -
Flags: review?(bas) → review+
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•