Closed
Bug 996960
Opened 12 years ago
Closed 12 years ago
Add new RTL languages to locales.nsi - Uyghur ug and Urdu ur
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
| Tracking | Status | |
|---|---|---|
| firefox28 | --- | unaffected |
| firefox29 | + | fixed |
| firefox30 | --- | fixed |
| firefox31 | --- | fixed |
| firefox-esr24 | --- | unaffected |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
(Keywords: rtl, Whiteboard: [stubv2=])
Attachments
(1 file)
|
459 bytes,
patch
|
ehsan.akhgari
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
Ehsan, would you mind reviewing this? Thanks!
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Attachment #8407242 -
Flags: review?(ehsan)
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [stubv2=]
|
||
Updated•12 years ago
|
Attachment #8407242 -
Flags: review?(ehsan) → review+
|
|
||
Comment 2•12 years ago
|
||
CCing Simon and Pike to keep them in the loop. We have two places to update when adding a new RTL locale.
Keywords: rtl
|
|
Assignee | |
Comment 3•12 years ago
|
||
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/ae585238d9a8
status-firefox29:
--- → affected
status-firefox30:
--- → affected
status-firefox31:
--- → affected
tracking-firefox29:
--- → ?
Flags: in-testsuite-
Target Milestone: --- → mozilla31
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 8407242 [details] [diff] [review]
patch rev1
[Approval Request Comment]
Bug caused by (feature/regressing bug #): This file was missed when adding the Urdu and Uyghur RTL locales.
User impact if declined: Urdu locale will not have a right to left installer or stub installer
Testing completed (on m-c, etc.): tested locally
Risk to taking this patch (and alternatives if risky): Extremely minimal
String or IDL/UUID changes made by this patch: None
Attachment #8407242 -
Flags: approval-mozilla-beta?
Attachment #8407242 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•12 years ago
|
|
||
Updated•12 years ago
|
Attachment #8407242 -
Flags: approval-mozilla-beta?
Attachment #8407242 -
Flags: approval-mozilla-beta+
Attachment #8407242 -
Flags: approval-mozilla-aurora?
Attachment #8407242 -
Flags: approval-mozilla-aurora+
|
|
||
Updated•12 years ago
|
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 6•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
status-firefox28:
--- → unaffected
status-firefox-esr24:
--- → unaffected
|
||
Comment 7•12 years ago
|
||
There are no ug or ur builds for Firefox 31 beta 1-4.
I've found Aurora 32.0a2 ur builds and the installer (and stub) properly displays from right to left.
Keywords: verifyme
|
||
Updated•3 years ago
|
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•