958577 - Add Uyghur to the list of RTL languages

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Axel Hecht [:Pike]]

Per http://en.wikipedia.org/wiki/Uyghur_language, we should add ug to our list of RTL languages.

Last time we did this was in bug 680255, for Urdu.

We have a localization effort in bug 571746, so setting up the dependency.

Comment 1

[(no longer active)]

Always happy to help add a new RTL language.  :-)

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 8358655 [details] [diff] [review]
Patch (v1)

Review of attachment 8358655 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm. I initially r-'ed this and wrote:

You also need to change the list of locales in IsBidiEnabled http://mxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#421. Extra credit for using intl.uidirection there if possible so we only have one hardcoded list to change next time!

... but on a second look I realise that IsBidiEnabled uses the system locale rather than the l10n locale. We should probably make it return true if *any* of the following is true: system locale is RTL; intl.uidirection is RTL; bidi.browser.UI is true. That can be a separate bug though.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d91785f387

Comment 5

[(no longer active)]

Filed bug 958985 as a follow-up for isBidiEnabled().

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b8d91785f387