Add Uyghur to the list of RTL languages

RESOLVED FIXED in mozilla29

Status

()

Core
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Pike, Assigned: Away for a while)

Tracking

Trunk
mozilla29
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Per http://en.wikipedia.org/wiki/Uyghur_language, we should add ug to our list of RTL languages.

Last time we did this was in bug 680255, for Urdu.

We have a localization effort in bug 571746, so setting up the dependency.
(Assignee)

Comment 1

4 years ago
Always happy to help add a new RTL language.  :-)
Assignee: nobody → ehsan
(Assignee)

Comment 2

4 years ago
Created attachment 8358655 [details] [diff] [review]
Patch (v1)
Attachment #8358655 - Flags: review?(smontagu)
Component: General → General
Product: Firefox → Core
Comment on attachment 8358655 [details] [diff] [review]
Patch (v1)

Review of attachment 8358655 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm. I initially r-'ed this and wrote:

You also need to change the list of locales in IsBidiEnabled http://mxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#421. Extra credit for using intl.uidirection there if possible so we only have one hardcoded list to change next time!

... but on a second look I realise that IsBidiEnabled uses the system locale rather than the l10n locale. We should probably make it return true if *any* of the following is true: system locale is RTL; intl.uidirection is RTL; bidi.browser.UI is true. That can be a separate bug though.
Attachment #8358655 - Flags: review?(smontagu) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8d91785f387
(Assignee)

Comment 5

4 years ago
Filed bug 958985 as a follow-up for isBidiEnabled().
https://hg.mozilla.org/mozilla-central/rev/b8d91785f387
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
(Assignee)

Updated

4 years ago
Depends on: 996960
You need to log in before you can comment on or make changes to this bug.