997051 - [Gallery] the MAX_IMAGE_SIZE in inline viewer doesn't not use customization config value

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

The MAX_IMAGE_SIZE is hardcoded as 5MB pixel. This should use customization config value.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ per dicsussion with product

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for 1.3t

this patch is for v1.3t. I will upload the patch for master and set the review flag to that patch.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: patch for master

Use CONFIG_MAX_IMAGE_PIXEL_SIZE in open.js.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

This is a defect in lots branches since bug 900399 landed, not torako only. So, we should patch it from leo to master if we need to do it.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

hi David, mind looking at this patch when you get a chance? Thanks

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8407422 [details] [review]
patch for master

Looks good to me. Thanks, John.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:

https://github.com/huchengtw-moz/gaia/commit/e6f67335b97a09d4f5e535ac7ff0746a6ce617d7

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to v1.3t:
https://github.com/mozilla-b2g/gaia/commit/fed1cc94e76abccea85ae998329430bb46cb7e53



commit hash is wrong of my last message, it should be:
https://github.com/mozilla-b2g/gaia/commit/f0463704888881b8ed1619e8d4b0d851b0e0311b

Comment 9

[thomas tsai]

Hi John: can you also generate a 1.4 patch? Thanks!

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sure Thomas. But this bug depends on bug 998228, do I need to generate both of them? Or do I just need to write the missing part of MAX_IMAGE_SIZE?

Comment 11

[thomas tsai]

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #10)
> Sure Thomas. But this bug depends on bug 998228, do I need to generate both
> of them? Or do I just need to write the missing part of MAX_IMAGE_SIZE?

I just want to confirm if this camera.json of tarako is also valid in dolphin after your 1.4 patch.
If the setting is still valid after your v1.4 patch, please generate 1.4 patch. thanks!
{
   "maxImagePixelSize": 2097152,
   "maxSnapshotPixelSize": 1920000,
   "maxGifImageFileSize": 1048576,
   "maxPickPixelSize": 480000,
   "maxEditPixelSize": 480000
}

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

We should enlarge the values for dolphin which is with 256MB. I cannot tell which value is correct. The patch of v1.4 may be just an uplift from master. I can do it. But we may need 1.4+ to land the code.

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

(In reply to thomas tsai from comment #11)
> {
>    "maxImagePixelSize": 2097152,
>    "maxSnapshotPixelSize": 1920000,
>    "maxGifImageFileSize": 1048576,
>    "maxPickPixelSize": 480000,
>    "maxEditPixelSize": 480000
> }

To telling more about this config file:
1. we may need to uplift bug 997051 to enable "maxImagePixelSize" in open.html
2. we may need to uplift bug 995148 to enable "maxGifImageFileSize" in app and open.html
3. we may need to uplift bug 989290 to enable "maxPickPixelSize" in app
4. we may need to uplift bug 998095 to enable "maxEditPixelSize" in app

Hope that helps.