997808 - [e10s] HTTP redirects don't redirect when HTTPS Everywhere addon is enabled

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Chris Peterson [:cpeterson]]

STR:
1. In an e10s window, load http://mozilla.org/

RESULT:
Instead of redirecting to http://www.mozilla.org/en-US/, Firefox displays the intermediate redirect page:

  Moved Permanently
  The document has moved here.


I think this is a recent regression.

Comment 1

[Steve Workman [:sworkman] (INACTIVE)]

Chris, this is working for me in an e10s window on OSX 10.9 with Nightlies 4/15, 4/16 and today's 4/17. Can you still reproduce it? If so, any other info you can provide?

Comment 2

[Chris Peterson [:cpeterson]]

This only happens when I have the HTTPS Everywhere addon enabled.

Comment 3

[Chris Peterson [:cpeterson]]

This is not a regression after all. I just had the HTTPS Everywhere addon disabled until recently.

Comment 4

[Steve Workman [:sworkman] (INACTIVE)]

Ah, I see. Still might be worth looking into.

Comment 5

[yan]

The redirects should work once ContentPolicy is not registered anymore in chrome.manifest (which it shouldn't be since we stopped using ContentPolicy a while ago). I fixed this in the stable git branch: https://github.com/efforg/https-everywhere/tree/4.0

You can run ./makexpi.sh to build an xpi to try it out, or wait til the next release.

Comment 6

[Chris Peterson [:cpeterson]]

Thanks, Yan!

Comment 8

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

Still seems to be broken on the https-everywhere 4.0 branch, rev d0638d8e39cd.  Firefox from current mozilla-central (gecko-dev git rev 77fe533a054f).

Comment 9

[Zack Weinberg (:zwol)]

Jacob Hoffman-Andrews is working on HTTPS Everywhere for EFF/Tor, but I'm not sure if he's the new permanent go-to guy.  cc:ed; can you help here?

Comment 10

[Chris Peterson [:cpeterson]]

* Jacob: I installed https-everywhere-4.0development.17.xpi and, with e10s enabled, I see the following error message in Firefox's Browser Console when trying to load "cnn.com":

> NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsILoadContext.associatedWindow] https-everywhere.js:425

* Ally: this looks like another nsILoadContext.associatedWindow problem. Are you planning to shim associatedWindow?

Comment 11

[Allison Naaktgeboren :ally]

afaik, objects aren't eligible for shims, but I think its an excellent candidate for a CPOW.

Comment 12

[yan]

Try building from https://github.com/diracdeltas/https-everywhere/tree/electrolysis (started working on e10s compatibility a long time ago).

Comment 13

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

(In reply to yan from comment #12)
> Try building from
> https://github.com/diracdeltas/https-everywhere/tree/electrolysis (started
> working on e10s compatibility a long time ago).

Redirects in e10s tabs work for me in that version.

Comment 14

[Chris Peterson [:cpeterson]]

Adding "dogfood" keyword so this bug shows up on the e10s wiki's list of known issues:

https://wiki.mozilla.org/Electrolysis#Known_Issues

Comment 15

[mrachuba]

After today's update https-everywhere still broken with e10s (36a1). Tried fresh profile and 5.0 development version of https-everywhere.

Comment 16

[Rapper_skull]

I have a similar problem, when there is an HTTPS redirect, the page is simply blank, nothing displayed. If I manually put https:// before the URL all works fine.

Comment 17

[Jacob]

We've landed Yan's electrolysis branch on master but haven't released it yet. I was doing some pre-release testing and found that non-e10s HTTPS Everywhere now has some regressions, related to getting null from channel.loadGroup. I'm at a bit of a dead-end. If any Mozilla folks would like to hop into the discussion on https://github.com/EFForg/https-everywhere/pull/526, or join me in #necko on irc.mozilla.org, I'd greatly appreciate the help.

Comment 18

[Chris Peterson [:cpeterson]]

Allison, can you take a look at the HTTP Everywhere error? It's odd that channel.loadGroup would work with e10s, but return null in non-e10s builds.

Comment 19

[Allison Naaktgeboren :ally]

Blake, I know nothing about channels, but I agree that something is fishy if it works with e10s but returns null for single process.  

I'm hoping you could shed some light on the issue

Comment 20

[alreiten]

With the new 5.0developement.1 build of HTTPS Everywhere, this issue looks now works for me.  I tested with the mozilla.org example and received the local version from the redirection.

Comment 21

[Chris Peterson [:cpeterson]]

Thanks for testing, alreiten. 5.0development.1 build works for me, too. I'd like to keep this bug open until HTTPS Everywhere's stable release is e10s compatible (i.e. updates from 4.0 to 5.0).

Comment 23

[Jacob]

As of HTTPS Everywhere 5.0.0, the stable release is e10s compatible. Please report any compatibility bugs to our GitHub issues page: https://github.com/EFForg/https-everywhere/issues

Comment 24

[Chris Peterson [:cpeterson]]

Thanks, Jacob!