1014986 - [e10s] HTTPS Everywhere addon meta bug

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Comment 1

[yan]

Apologies if this belongs somewhere else, but I managed to get HTTPS Everywhere to be e10s compatible as far as I can tell: https://github.com/EFForg/https-everywhere/pull/526. Let me know if you find bugs.

To test it out, clone the pull req. and run ./makexpi.sh to build an xpi.

Comment 2

[Chris Peterson [:cpeterson]]

Adding "dogfood" keyword so this bug shows up on the e10s wiki's list of known issues:

https://wiki.mozilla.org/Electrolysis#Known_Issues

Comment 3

[Allison Naaktgeboren :ally]

(In reply to yan from comment #1)
> Apologies if this belongs somewhere else, but I managed to get HTTPS
> Everywhere to be e10s compatible as far as I can tell:
> https://github.com/EFForg/https-everywhere/pull/526. Let me know if you find
> bugs.
> 
> To test it out, clone the pull req. and run ./makexpi.sh to build an xpi.

Thank you Yan. Juanb, would you please verify that that the updated addon works with e10s?

Comment 4

[juan becerra [:juanb]]

I built an xpi from the e10s branch, and I installed it on the latest Nightly on Mac. I have been dogfooding it this morning without any problems. There are redirects to https for sites where available, and, if I specify it in the add-on, sites that do not have https are blocked. I'll continue to dogfooding it, but so far so good.

Comment 5

[Frederik Braun [:freddy]]

Should we mark this as fixed then?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Frederik Braun [:freddyb] from comment #5)
> Should we mark this as fixed then?

No, we should leave this bug open until the stable release of HTTPS Everywhere is e10s-compatible. Currently, neither the 4.0 stable or 5.0 development releases (on https://www.eff.org/https-everywhere) are e10s-compatible. I just retested them.

Comment 7

[Allison Naaktgeboren :ally]

Telemetry data indicates that https everywhere regularly throws 3 different js exceptions.

FILE_NOT_FOUND 0 (probably means attempting to load some file throws)

toolbar_button.js 64

tabbrowser.xml 430

Comment 8

[Dave W.]

HTTPS-Everywhere 5.0 stable is working on Nightly now.

Comment 9

[Chris Peterson [:cpeterson]]

Jacob from the EFF says HTTPS Everywhere 5.0.0, the stable release, is e10s compatible. Please report any compatibility bugs to the EFF's GitHub issues page: https://github.com/EFForg/https-everywhere/issues

Comment 10

[Giorgio Maone [:ma1]]

=== Add-on/e10s tracking summary ===

Assignee: Giorgio Maone

Link to add-on: https://addons.mozilla.org/en-us/firefox/addon/https-everywhere/

Contact info for add-on: https://github.com/EFForg/https-everywhere/issues

Add-on ID: [e-mail]

How well does it work?: 100%

Steps to reproduce working features:
* Visit http://www.intensitylab.com/ -- the site should actually be opened as https://www.intensitylab.com/
* Click on the HTTPS Everywhere toolbar icon and play with the option

Steps to reproduce broken features: ---

Any obvious performance problems? no

SDK-based: No, legacy XUL (non-bootstrapped)

Chromium version: https://chrome.google.com/webstore/detail/https-everywhere/gcbommkclmclpchllfjekcdonpmejbdp