999511 - When user exports contacts via Bluetooth, Not valid Title in "unable pair devices" screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-04-22-12-26-31.png

Tested
Hamachi 
1.4
Gecko 53aec4a
Gaia 2643291

Reproducible 100%

STR

STR
1. Tap contact aplication.
2. Tap settings.
3. Tap "Export contacts".
4. Tap Bluetooth.
5. Select all
6. Tap Export button.
7. Appear all devices in the area.
8. Select a device, and see "Bluetooth transfer" screen.
9. Tap OK.
10. Tap "X" button (close button) in "Bluetooth" screen.

Actual result:
Screen with not correct title. (see image attached)

Expected result:
Screen with correct title.

Comment 1

[Noemí Freire (:noemi)]

Attachment: 2014-04-22-master.png

The issue DOES NOT OCCUR on today's (4/22) master build:
Device: Hamachi
BuildId: 20140422065611
Gecko: 22b3e73
Gaia: f046370
Platform version: 31.0a1

Comment 2

[Noemí Freire (:noemi)]

qawanted to check if it occurs on v1.3 branch. Thanks!

Comment 3

[Loli (:lolimartinezcr)]

(In reply to Noemí Freire (:noemi) from comment #2)
> qawanted to check if it occurs on v1.3 branch. Thanks!

Tested and working in
Hamachi 
1.3
Gecko: 1949f0e
Gaia: fb2b8e2

Comment 4

[Noemí Freire (:noemi)]

It seems to be an issue related to v1.4 branch so setting v1.4? flag. Thanks!

Comment 5

[Preeti Raghunath(:Preeti)]

Blocking for title clean up. Likely cert blocker in the past and hence blocking

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

We are blocked here by bug 1000061

Right now the bluetooth share activity needs a path in the file system to show a name. Unless we have that resolved, this one won't be able to be fixed.

Comment 7

[Noemí Freire (:noemi)]

(In reply to Francisco Jordano [:arcturus] from comment #6)
> We are blocked here by bug 1000061
> 
> Right now the bluetooth share activity needs a path in the file system to
> show a name. Unless we have that resolved, this one won't be able to be
> fixed.

Clearing Bug 1000061 dependency since this bug is not related to the fact of not having SD card but the wrong title appearing in the error message while pairing BT devices.

Comment 8

[Duane Dixon [:ddixon]]

B2G Inbound Regression Window

Last working Build:

Environmental Variables
Device: buri
BuildID: 20140401164924
Gaia: ac28dec0257997231f403e056dd71a326fb90010
Gecko: 0e358d5c2f75
Version: 31.0a1
Firmware Version: v1.2-device.cfg

First Broken Build: 

Environmental Variables
Device: buri 
BuildID: 20140401170724
Gaia: e7dd2bea50712389583bf989325b30f7097c5e8c
Gecko: 29c87da538e1
Version: 31.0a1
Firmware Version: v1.2-device.cfg

Last Working Gecko First Broken Gaia: 
Issue DOES occur here.
Gaia: e7dd2bea50712389583bf989325b30f7097c5e8c
Gecko: 0e358d5c2f75

Last Working Gaia First Broken Gecko: 
Issue DOES NOT reproduce here.
Gaia: ac28dec0257997231f403e056dd71a326fb90010
Gecko: 29c87da538e1

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/ac28dec0257997231f403e056dd71a326fb90010...e7dd2bea50712389583bf989325b30f7097c5e8c

Comment 9

[Jason Smith [:jsmith]]

bug 982006 broke this.

Aus - Can you take a look?

Comment 10

[Aus Lacroix [:aus]]

Hi Jason,

Yes, I'll take a look. I was just looking at that code yesterday after an NI? request on another bug. I have a pretty good idea of what's going on and how to fix it. It'll be a simple gaia change.

Comment 11

[Aus Lacroix [:aus]]

Attachment: Pull Request - Use URL object to compare origins instead of app.config.url and app.config.origin

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8412887 [details] [review]
Pull Request - Use URL object to compare origins instead of app.config.url and app.config.origin

r+ if you have unit test.

Comment 13

[Aus Lacroix [:aus]]

Yep, there's a unit test for this already in app_modal_dialog_test.js :)

Comment 14

[Aus Lacroix [:aus]]

Commit (v1.4): https://github.com/mozilla-b2g/gaia/commit/b59041c921efeab8d638eb627cac475443bfaec5

Commit (Master): https://github.com/mozilla-b2g/gaia/commit/725a23802708eb70e3d7e8a2ce7179adbac806e4

There we go! Tested on a GP Peak with 1.4.

Comment 15

[Loli (:lolimartinezcr)]

Tested and working
1.5
Hamachi
Gecko: 13b2542
Gaia: 08ea844

1.4
Hamachi
Gecko: 57e0c0a
Gaia: 81e97c3