Closed Bug 242864 Opened 20 years ago Closed 18 years ago

Delete key does not delete messages on MAC

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: cam_s, Assigned: Bienvenu)

References

Details

(Keywords: fixed1.8.1, verified1.8.1.3, Whiteboard: dupme)

Attachments

(2 files, 1 obsolete file)

First crack at porting the suite patch over to thunderbird
12.63 KB, patch
Bienvenu
: review+
Details | Diff | Splinter Review
Should fix regression (I hope) as well as keep fix for Delete key
2.49 KB, patch
Bienvenu
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040505 Camino/0.7+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a) Gecko/20040505 Camino/0.7+

See summary.  Clicking the delete icon in the toolbar works, but pressing the
delete key does nothing.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Whiteboard: dupme
Hmm... the backspace key (which says 'delete' on the mac keyboard) works, but
the delete key (next to the home and end key) doesn't work.  This is
inconsistent with Apple mail.  Is this the intended behaviour?
The delete key didn't work on Linux but now it does on the v0.7+ 20040731 nightly.

Please close this bug if it is fixed on the Mac.

This is Seamonkey bug 57510 -- Scott, is that the bug you wanted this duped to, 
or could the fix be TB-only?
I don't remember anymore if that's the bug I was thinking of :)
*** Bug 259299 has been marked as a duplicate of this bug. ***
Status: UNCONFIRMED → NEW
Ever confirmed: true
I have this bug too, running version 1.0 under XP. The 0.9 version perfectly.
Now when I download emails then want to delete a couple, I can't. I have to
close Thunderbird, start it then I can delete. I'm not sure if this happens
under Linux, I have to try it out this week.
Just to reinforce this one. I cannot delete messages from my mailbox using the
key marked 'Delete' on my keyboard (this is the one grouped with Insert, Home,
End etc.) the 'Backspace' key works fine.

This is with Thunderbird version 1.0 (20041206)

I'm using a Logitech 'Elite' USB keyboard plugged into a Mac Mini running OS X
(10.3.8) all of the other normal keys seem to work fine in the Mac context.

All in all, I prefer T-bird to Mail. I can't wait for the next version.

BY
For as long as I can remember, the "del" key next to 'home' and 'end' has never
deleted messages in Mozilla for the Mac.  What's odd is that the del key does
delete bookmarks in the Bookmark Manager, but the 'delete' key doesn't.

So I can verify that this problem still exists with Mozilla 1.7.5 on OS X 10.3.8.
Windows 2k pro sp4 ande all patches.  TB 1.0.5.  If i hold down the delete key
and hold it down..only about 10 messages get deleted then the delete operation
simply stops.  This issue is NOT present in seamonkey.  I can hold down delete
in a folder of 500 items and it iwll delete all of them..thunderbird will not.
William, have you tried a Thunderbird 1.1a build? Several bugs in this area have
been fixed. Re mac issues, that sounds like a toolkit issue.
No I have not...but i will once it is released GA.
I just gave 1.1a2 (Version 1.0+ 20050712) a whirl on Mac OS 10.3 and it does not
fix this bug.
is your bug "If i hold down the delete key and hold it down..only about 10
messages get deleted..." or just that the delete key isn't bound to the delete
operation? I don't know anything about the latter, but some bugs that might have
caused the former have been fixed.
(In reply to comment #13)
> is your bug "If i hold down the delete key and hold it down..only about 10
> messages get deleted..." or just that the delete key isn't bound to the delete
> operation? I don't know anything about the latter, but some bugs that might have
> caused the former have been fixed.the delete operation only repeats for about
10 messages when the delete key is held down..then it simply quots.

Message #12
>> I just gave 1.1a2 (Version 1.0+ 20050712) a
>> whirl on Mac OS 10.3 and it does not
>> fix this bug.

Message #13
> is your bug "If i hold down the delete
> key and hold it down..only about 10
> messages get deleted..." or just that
> the delete key isn't bound to the delete
> operation? I don't know anything about
> the latter, but some bugs that might have
> caused the former have been fixed.


I only tested the original bug...that the delete key doesn't delete messages. 
The other bug (deleting ~10 messages) was tacked on in comment #9 should really
be treated as a different bug.  I did not test if that is resolved.
mscott - dup to bug 57510?

(In reply to comment #14)
> (In reply to comment #13)
> > is your bug "If i hold down the delete key and hold it down..only about 10
> > messages get deleted..." or just that the delete key isn't bound to the delete
> > operation? I don't know anything about the latter, but some bugs that might have
> > caused the former have been fixed.the delete operation only repeats for about
> 10 messages when the delete key is held down..then it simply quots.

see Bug 265343  (happens to me at the second quick delete)


another weird mac delete bug - Bug 242723
Summary: Delete key does not delete messages → Delete key does not delete messages on MAC
*** Bug 328863 has been marked as a duplicate of this bug. ***
sorry about posting a dupe bug.  I can confirm this on new Intel Mac, thunderbird 1.5.0.1, OS X 10.4.5.  The 'backspace' delete key works, but the 'delete' key next to the 'end' key does not work.

I also tried the 'unofficial' universal binary for Thunderbird (1.5.0.2) and that has the same problem.


Note that there is a patch in progress for this problem, for the suite, 
at bug 57510.
The Seamonkey patch I believe is trunk-only (will be in SM 1.5).  Patch author stated the patch was Seamonkey-only, so it needs to be ported to get to TB.
I'll try to get to this for TB.
Assignee: mscott → bienvenu
I just Switched to Mac last week (Intel Mac Mini with 10.4.6) and Swedish Apple Wirered Keyboard. The first annoyance I found related to MacOS was that I now needed to delete emails i TB (1.5.0.4) by pressing the <DELETE> rather than pressing the delete button (The one below the help button).
Today I googled and found out that emails is delete by pressing the Backspace button, I don't see the logic in that, since the <DELETE> button works both in The Windozeee and Linux version.

This Bug need some immediate love by you guys, with hopes to see a fix in 1.5.0.5 :D

Best Regards
Patrik

Scott and David, this is killing me. Any chance you can get this in for 2.0?
Flags: blocking-thunderbird2?
If there's been no progress since comment #21, please let me know and I'll go ahead and give porting over the Suite patch a go. Just switched to Thunderbird on the Mac this morning, and WOW, this bug is a huge usability oversight... gotta get this fixed.
Tim, thanks!!!!!
Tim, that would be great. This fell off my radar, unfortunately.
Tim can you work on this? Thanks!
Flags: blocking-thunderbird2? → blocking-thunderbird2+
Please keep in mind that I'm not too knowledgeable about the inner workings of Thunderbird, and this patch was mainly just an attempt to try to port over what had already been done on the Suite side of things. That said, there were several discrepancies that hopefully have been accounted for in the proper files. I've compiled my own build with this patch for PPC 10.4, and it seems to work fine. At the very least, hopefully this can be a jumping off point for someone more experienced to pick-up from.
Attachment #238082 - Flags: review?(bienvenu)
Comment on attachment 238082 [details] [diff] [review]
First crack at porting the suite patch over to thunderbird

thx very much, Tim. This looks good. I'll try it on my Mac just to be sure, and then check it in if there are no problems.
Attachment #238082 - Flags: review?(bienvenu) → review+
fixed on trunk and branch - Asa, can you try tomorrow's build and verify that the delete key works for you now? Thx! And thx again to Tim.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
this patch broke shift-delete on windows, see:

http://forums.mozillazine.org/viewtopic.php?t=463069&sid=a487ab6a58f6f70e87d774e4c6e2e507

It also caused a regression in the compose window on the branch so adding that bug as a dependency.
Depends on: 352527
re shift delete, I'm not sure, but I think the issue is that TB doesn't seem to be using the platformMailnewsOverlay.xul files it defines - I couldn't find references to them in the jar files.
Attached patch fix shift delete regression (obsolete) — — Splinter Review 
not sure this doesn't regress the original bug, but I don't think it will.
Attachment #238225 - Flags: superreview?(mscott)
Tim, can you make sure this most recent patch doesn't break the original fix on the Mac? I just backed out the mailWindowOverlay.xul changes because they depend on files we don't use...
I'll check it out. It'll take about 30 mins to recompile.
you just need to rebuild from mozilla/mail - no real recompile needed :-)
Comment on attachment 238225 [details] [diff] [review]
fix shift delete regression

This patch broke the fix for the Delete key on the Mac.
Attachment #238225 - Flags: superreview?(mscott) → superreview-
David, unfortunately that patch caused the Delete key to stop working. I've taken the general "idea" of the one you created and I think successfully made it so that the regression will still be taken care of. I've tested this on mine and Delete and Shift+Delete work fine like my original. Don't have a means of compiling a windows build though, so I'm unsure as to whether or not the regression is 100% taken care of.

Thanks.
Attachment #238225 - Attachment is obsolete: true
Attachment #238255 - Flags: review?(bienvenu)
thx, Tim, I'll try this out on Windows as soon as I can after I finish debugging some pop3 code.
Comment on attachment 238255 [details] [diff] [review]
Should fix regression (I hope) as well as keep fix for Delete key

yup, works for me on windows, thx. I'll try it on 2.0 as well...
Attachment #238255 - Flags: review?(bienvenu) → review+
Comment on attachment 238255 [details] [diff] [review]
Should fix regression (I hope) as well as keep fix for Delete key

yup, works for me on windows, thx. I'll try it on 2.0 as well...
ok, I landed Tim's patch on the trunk and branch.
Depends on: 355169
verified fixed on the branch using the Tbird candidate build, version 2.0.0.0 (20070326). Adding branch verified keyword. Verified on a PPC mac running 10.4.9.
Keywords: verified1.8.1.3
What about SeaMonkey?  Bug 57510 is for the "suite", and it was fixed in June 2006, but I'm using SeaMonkey 1.1 and it's not fixed. What is the equivalent to this bug for SeaMonkey?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: