355169 - all navigation keys (tab, arrows, enter) delete messages in advanced search results

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

1. advanced search, choose folder with several messages you don't care about, like trash
2. search for subject " "
3. click any message
4. hit any navigation key

message deleted

after step 4
5. click in subject search input area
6. hit any navication key

message deleted

reproducible: always

20060911 works fine
fails:
version 3 alpha 1 (20060926)
version 3 alpha 1 (20061002)

Comment 1

[David :Bienvenu]

It would be really interesting if the 9/18 build worked, and the 9/19 build didn't - then the fix for bug 350030 would be a likely suspect.

Comment 2

[David :Bienvenu]

this broke from checkins on 9/12 - the 9/12 build works, the 9/13 build is broken.   The leading suspect would be this patch that I checked in - https://bugzilla.mozilla.org/show_bug.cgi?id=242864

Comment 3

[David :Bienvenu]

Attachment: proposed fix

I don't know why if you can't indent #ifdefs, you don't get syntax errors, but this seems to fix the problem.

Comment 4

[Scott MacGregor]

Comment on attachment 241011 [details] [diff] [review]
proposed fix

yeah, you can't have white space before (or after for that matter) a xul pre-processor define. I've never thought to understand why :).

Comment 5

[Mike Cowperthwaite]

Comment on attachment 241011 [details] [diff] [review]
proposed fix

Arrow keys worked before this fix (they're only used to navigated radio buttons).

This same problem exists in the 1.8.1 branch: bug 348263.

Comment 6

[David :Bienvenu]

the 1.8.1 branch doesn't have this exact problem (cursor keys don't delete messages) but it does have the whitespace issue, so I'll check the fix in for that.

Comment 7

[David :Bienvenu]

fix checked in on 1.8.1 branch 

Comment 8

[Scott MacGregor]

Comment on attachment 241011 [details] [diff] [review]
proposed fix

this is fixed on the 1.8.1 branch already. Clearing the 1.8.1 approval flag.

Comment 9

[Adam Guthrie]

*** Bug 353477 has been marked as a duplicate of this bug. ***

Comment 10

[Marcia Knous [:marcia]]

verified using a Windows Thunderbird candidate build, version 2.0.0.0 (20070326). I followed the STR in Wayne's initial report, and no emails were deleted. Adding keyword.