898354 - [User Story] Timer Notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Peter Dolanjski [:pdol]]

User Story:

As a user I want to be notified when the specified count down time has elapsed so that I don't need to keep track by keeping the count down timer open.


Acceptance Criteria:

1. If my device volume is not set to silent, after the count down reaches 0, I am visually and audibly notified.
2. If my device volume is set to silent, after the count down reaches 0, I am visually notified.

Comment 1

[Peter Dolanjski [:pdol]]

Accidental nom.  Not a blocking feature.

Comment 3

[Eric O'Connor [:oconnore]]

Attachment: github pr

Hey Mike,

This patch is ready for review.

Comment 4

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8347420 [details] [review]
github pr

Alright, Eric! I've finished reviewing the patch--comments on the GitHub pull request.

Comment 5

[Eric O'Connor [:oconnore]]

Comment on attachment 8347420 [details] [review]
github pr

Ok Mike, I made changes per your review. Let me know how it looks.

Comment 6

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8347420 [details] [review]
github pr

Hi Eric,

I think we're almost there. See the pull request on GitHub for in-line review comments.

Comment 7

[Eric O'Connor [:oconnore]]

Comment on attachment 8347420 [details] [review]
github pr

code++

Comment 8

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8347420 [details] [review]
github pr

Give me an e-holler when you get the Snooze bug worked out!

Comment 9

[Eric O'Connor [:oconnore]]

Comment on attachment 8347420 [details] [review]
github pr

yo!

Comment 10

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8347420 [details] [review]
github pr

Looking good!

Comment 11

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/gaia/commit/8862901daa7b9befce33d1d679091f26437386d1

Nice work, Eric

Comment 12

[Mike Pennisi [:jugglinmike]]

reverted: https://github.com/mozilla-b2g/gaia/commit/b835ffc38821c7693877a158ca2f961890b7fcd8

Eric: that patch caused the Timer panel to re-draw much too often. The `tickTimeout` calculated by `Timer.Panel#tick` should reference `this.startTime` instead of `this.start`. Could you please update your patch to avoid this inefficiency?

Sorry I didn't catch this sooner.

Comment 13

[Eric O'Connor [:oconnore]]

Attachment: github pr

Hey Mike, this should fix the performance regression.

Comment 14

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8360701 [details] [review]
github pr

Thanks, Eric

Comment 15

[Mike Pennisi [:jugglinmike]]

master: https://github.com/mozilla-b2g/gaia/commit/ef8bb31b462f364b57432a0724c78034d3f4f303

Comment 16

[Dylan Oliver [:doliver]]

Clearing nomination; this is a 1.4 feature but it's too late to add this to 1.3.

Comment 17

[Jack Liu]

Dears,

If don't add this to v1.3, the usability of timer will be seriously discounted, what do you think? 
Please land it to v1.3, there is still time to complete this work.

Thanks.

Comment 18

[Dylan Oliver [:doliver]]

We agree that this is an important enhancement to the Timer but we are too far past the feature complete date to attempt uplift of this feature. There are a number of other dependent bugs here as well -- it's too risky to pull this in to 1.3.