1006794 - Support extension metadata filters in blocklist tool

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Bug 897735 implemented some advanced blocklisting features we needed to deal with tricky blocks like bug 936214. We need to modify the blocklisting form so that it supports these types of blocks.

The current form supports blocking by "id", and now we also need to add "name", "creator", "homepageURL", and "updateURL". That also means "id" is now optional, if it wasn't already. This all applies for the "Blocklist Items" section, not plugins or gfx.

Let me know if there are any questions, I know this tool is a bit confusing.

Comment 1

[Mathieu Agopian [:magopian]]

When I go in the blocklist admin (/en-US/admin/models/blocklist/blocklistdetail/add/), I can see, in the "items" section, the following fields:

- Guid
- Min
- Max
- Os
- Severity

So, are you talking about Guid when you say that "id" should be option? (if so, it is already).

And then, we need to add the following (optional) fields: name, creator, homepageURL and updateURL (which will all appear in the XML if they're filled in)?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Mathieu Agopian [:magopian] from comment #1)
> So, are you talking about Guid when you say that "id" should be option? (if
> so, it is already).

Yes, I'm talking about the guid. If it is already optional, there's nothing to do about it.

> And then, we need to add the following (optional) fields: name, creator,
> homepageURL and updateURL (which will all appear in the XML if they're
> filled in)?

Yes.

Comment 3

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/143

Comment 4

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/ed53a84065e4df850102b597bbc4b5cbc8973367

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Looking at bug 897735, there appears to be a mismatch between what is done here and what Firefox expects. The extra values being added are expected as attributes, not separate nodes:

https://hg.mozilla.org/mozilla-central/rev/c8e2cb87f6c1#l9.3

Comment 6

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/151

Comment 7

[Mathieu Agopian [:magopian]]

(re)fixed in https://github.com/mozilla/olympia/commit/7185a3306c538a28f3ab84c15276c567a1d6f0b3

Those are now attributes, not tags anymore.

When testing, please make sure the blocklist displayed has been regenerated!