1007933 - [User Story] As a user I would like to be able to make a call directly from the address book contact details

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect, P1)

Comment 1

[Romain Testard [:RT]]

Facebook contacts which may have been imported on the phone are excluded from the Loop contact integration for legal reasons.

Comment 2

[Maria Angeles Oteo (:oteo)]

(In reply to Romain Testard [:RT] from comment #1)
> Facebook contacts which may have been imported on the phone are excluded
> from the Loop contact integration for legal reasons.

In the specific case of this US, we are calling directly from the Address Book (not from Loop Application). Is this a problem? I understand that Loop application should not be able to read FB Data Store but in this US is the contact application the one reading it and just making a call to Loop.

Comment 3

[Romain Testard [:RT]]

The issue is about providing Facebook contact data to a third party application.
Even if the trigger would be made from the contact application, the Loop application would be using either the MSISDN or the email address (which both would come from FB) to initiate the call, right?

Comment 4

[Daniel Coloma:dcoloma]

(In reply to Romain Testard [:RT] from comment #3)
> The issue is about providing Facebook contact data to a third party
> application.
> Even if the trigger would be made from the contact application, the Loop
> application would be using either the MSISDN or the email address (which
> both would come from FB) to initiate the call, right?

If this is the legal advise, FirefoxOS has then a bigger issue as the contacts application exposes a picker activity that basically allows any application to get the details of any contact (including data imported from FB). The flow of data imported from FB is exactly the same in both cases so I would say that if this  User Story cannot be implemented because of legal reasons we should also change the picker activity in contacts so that it does not expose the information imported from FB. Please note that Loop was also planning to do this (using Picker Activity) in order to get access to contacts information and not maintaining a different Database.

I was involved in the initial discussion to sign the agreement with FB and the intention behind that agreement was protecting programatical access to FB Data (e.g. via APIs). I think sending a phone number or e-mail to Loop application so it can make a call to it, especially when the user has proactively clicked on the Call via Loop button in the contacts detail view, is explicit consent from an end-user point and something not inline with what FB tried to prevent. However, I am not a lawyer so I might be totally wrong. 

Romain, can you please double check? This is critical as it affects FirefoxOS as a whole, CCing Wilfred as he is the Comms PM.

Comment 5

[Romain Testard [:RT]]

I copy Geoff who hopefully can answer your question in details.

Comment 6

[Geoff Piper]

Happy to have a meeting about this as it seems it is warranted since there are several threads/bugs/comms going on around this.

I will reiterate here. We do not have to my knowledge to date an agreement with Facebook that would allow this. We would need a separate agreement with Facebook (they are restrictive about use of contacts this way).

Comment 7

[Daniel Coloma:dcoloma]

Let me summarize the three use cases I see for the Loop app. Please bear in mind that the first one is already implemented in the platform an open to any app. Could you please let us know if you believe which use cases are feasible and which ones are not? Happy to have a meeting if that speeds things up but I think the description below should be clear enough to start taking decisions.

USE CASE 1

Any application, even if it is a hosted app can invoke contacts application through activities. There is one activity called picker that allow any third party app to get for instance the phone number of a contact. That phone number could be, for instance, a phone number that was imported from FB. The flow should be something like:
    
 - 3rd Party app invoke picker
 - Contacts app shows list of contacts
 - User selects one
 - Phone Number is sent back to the 3rd Party app

This is implemented today and used by many 3rd party apps. The plan was to use this mechanism in Loop. 

USE CASE 2

Contacts Application send information related to the data imported from FB to another application upon a specific user action. For instance, in our case the flow would be:

 - Contacts show the details of a contact (including, for instance a FB phone number) and shows a button to invoke Loop
 - User click on the Call Loop button
 - The phone number is sent to Loop so it can call the phone number the user has selected
   
USE CASE 3

In use cases 1 and 2 the Loop application can call the phone number that has been passed but cannot know the name linked to that phone number entry. 

E.g. A contact in the address book with name “Daniel Coloma” and phone number imported from FB [phone]. If that number is called via Loop by the Use Cases 1 or 2, Loop will show an ongoing call to [phone] but not an ongoing call to Daniel Coloma. The same would happen in the Call Log. 

This could be solved by allowing programatic access (via Data Store API) to the FB Data stored in the Data Store. A prompt could be shown when Loop app tries to access FB DataStore if that makes this use case inline with any agreement.

Comment 8

[Geoff Piper]

Let's meet about this. Please set one up. I believe FB contacts import/use requires a license with FB which we don't have to my knowledge.

Comment 9

[Daniel Coloma:dcoloma]

(In reply to Geoff Piper from comment #8)
> Let's meet about this. Please set one up. I believe FB contacts import/use
> requires a license with FB which we don't have to my knowledge.

Yes, let's arrange a meeting. I'll ping you offline. In the meantime, there is an agreement between Mozilla and FB, and I pretty positive about this but I think Chris can confirm (ni on him).

Comment 10

[Geoff Piper]

Send me this agreement that you have so I can see it please. I don't believe we have any kind of agreement with FB that handles contacts.

Comment 11

[Geoff Piper]

Posting same comment here for everyone's benefit on this bug, from Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1006053

I believe I am better equipped to assist here now having seen all of our Facebook agreements on point. If we need a meeting I understand and that might be helpful for several reasons, mainly so I can fully understand what we are doing with Facebook contacts and Loop. 

To summarize, via the Facebook Social API agreement and extended API amendment, we have the following rights:

"Firefox OS offers users the ability to Import his/her Facebook's contacts Into the Contacts app. The Import pulls the contact's uld, name,firs.t_name, last_ name, pic_blg, current_location, mlddle_name, birthday_date, email, profile_update_tlme, work, phones, hometown_location based on the availability of the data. Once the user imports contacts from Facebook, those contacts are downloaded and available on the native device's contacts app only. 

Those contacts are stored locally on the device and once a user logs out of Face book through the integration, the OS deletes the locally stored Facebook contact data. Any imported Facebook contacts could never be uploaded to a remote server through default built-In Fire fox OS functionality."

This means we do not have the ability to sync, aggregate or copy off the device. It is to be client stored only.

Please let me know if you would like to speak more about this or if you think a meeting will be productive.

Comment 14

[Maria Angeles Oteo (:oteo)]

Included offline AC

Comment 15

[Maria Angeles Oteo (:oteo)]

Updated the US with the termination reasons in https://wiki.mozilla.org/Loop/Architecture/MVP#Termination_Reasons