1011542 - Add native rm.exe to rev2 builder image

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: General, task)

Description

[Chris Cooper [:coop] (he/him)]

Vlad wrote a replacement for the msys version of rm.exe that uses Windows-native calls that substantially increases the performance of recursive file/dir removals. The replacement is drop-in, has been tested over in bug 692715, and in the interest of speed I've already deployed it to all the Windows builders by hand using the following stanza:

 cd /bin 
 if [ ! -e rm-msys.exe ]; then cp rm.exe rm-msys.exe; fi
 if [ -e winrm.exe ]; then rm winrm.exe; fi
 wget http://people.mozilla.com/~vladimir/misc/winrm.exe
 cp winrm.exe rm.exe

Can we please get this new version of rm.exe added to the rev2 image for the Windows builders (w64-ix, b-2008-ix, and b02008-sm)? We'd like to keep the old version of rm.exe (preserved as rm-msys.exe, as above) in case we need to rollback.

rm.exe lives in C:\mozilla-build\msys\bin

Thanks!

Comment 1

[Hal Wine [:hwine] use NI!]

This bit us on move train A -- comment 0 needs to be manually applied to any freshly imaged builders until this bug is r/f.

Comment 2

[Hal Wine [:hwine] use NI!]

Attachment: rebuild_windows_builders.txt

List of move train A hosts that need to have comment 0 applied, and then be re-enabled in slavealloc.

Comment 3

[Hal Wine [:hwine] use NI!]

Comment on attachment 8427422 [details]
rebuild_windows_builders.txt

(In reply to Hal Wine [:hwine] (use needinfo) from comment #1)
> This bit us on move train A -- comment 0 needs to be manually applied to any
> freshly imaged builders until this bug is r/f.

This has been applied to move train A windows builders & hosts re-enabled.

Still a blocker for future move trains.

Comment 4

[Q]

Working on getting this into gpo and the build image. Is this going to be part of mozbuild 1.9 or will it continue to need to be replaced after 1.9 deploys?

Comment 5

[Chris Cooper [:coop] (he/him)]

I(In reply to Q from comment #4)
> Working on getting this into gpo and the build image. Is this going to be
> part of mozbuild 1.9 or will it continue to need to be replaced after 1.9
> deploys?

It is not part of MozillaBuild 1.9.

Comment 6

[Q]

Files are set in GPO for current and future deploys

Comment 7

[Chris Cooper [:coop] (he/him)]

Is there anything left to do here then, or can we close this out?

Comment 8

[Q]

I think we can close this out.