1011616 - Join Chat dialog box won't close with Auto-join this Chat Room checked

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[WaltS48 [:walts48]]

Attachment: Screenshot

Sign-on to a chat account
Click Join Chat
Enter a Channel name in the Join Chat dialog box
Place a check mark to enable 'Auto-join this Chat Room'
Click OK

Chat room is joined, but the Join Chat dialog box doesn't close

Comment 1

[WaltS48 [:walts48]]

Attachment: auto-join.png

2nd attempt at a visual

Comment 2

[Patrick Cloke [:clokep]]

Are there any errors in the error console? Does this only happen when you check "Auto-join this Chat Room"?

Comment 3

[WaltS48 [:walts48]]

Only happens when I check "Auto-Join this Chat Room", otherwise it closes.

No errors in the Error Console.

Thanks for removing my mistake.

Comment 4

[Patrick Cloke [:clokep]]

I'm able to reproduce this on Daily.

Comment 5

[Patrick Cloke [:clokep]]

Looks like this needs to port https://hg.mozilla.org/comm-central/rev/ab630c829a4b I'm going to sync im & mail versions of this file.

Comment 6

[Patrick Cloke [:clokep]]

Attachment: Patch v1

Porting the focusing of the conversation seemed like too big of a change for this bug, but the current diff is pretty small.

Comment 7

[Patrick Cloke [:clokep]]

Attachment: DIff of im and mail joinchat.js

Comment 8

[Patrick Cloke [:clokep]]

By the way this is a regression due to bug 920801, commit https://hg.mozilla.org/comm-central/rev/01a788d85004

Comment 9

[Patrick Cloke [:clokep]]

Comment on attachment 8425941 [details] [diff] [review]
Patch v1

https://hg.mozilla.org/comm-central/rev/678a0897be2a

[Approval Request Comment]
Regression caused by (bug #): bug 920801 (https://hg.mozilla.org/comm-central/rev/01a788d85004)
User impact if declined: Unable to add chat rooms to the auto-join list from the "Join Chat" menu. Current aurora will be the next version of TB to go to the release channel.
Testing completed (on c-c, etc.): Committed to c-c, I've tested this by hand, we can let it bake on c-c and ask the reporter to ensure the bug is fixed though.
Risk to taking this patch (and alternatives if risky): I see this as pretty low risk, it's porting a change that has been in Instantbird since Oct. 14, 2013 (~7 months).

Comment 10

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/00b489b31ed1

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8425941 [details] [diff] [review]
Patch v1

This landed before the merge, so no need for a separate beta landing.