1019924 - Update license.html for Loop-related third-party licenses

Status: VERIFIED FIXED

(mozilla.org :: Licensing, task, P1)

Description

[Adam Roach [:abr]]

This is the update to license.html that needs to land once we have approval for the various third-party libraries we're using in Loop.

Comment 1

[Adam Roach [:abr]]

Attachment: Update license.html for Loop-related third-party licenses

Comment 2

[Adam Roach [:abr]]

Note that we have sign-off on the lodash license in Bug 975548.
For the OpenTok license sign-off, see Bug 956821.

Comment 3

[Adam Roach [:abr]]

[Note that I read Gerv's comment in Bug 975548#c22 as applying to both Lodash and Backbone]

Comment 4

[Adam Roach [:abr]]

Attachment: Update license.html for Loop-related third-party licenses

Comment 5

[Adam Roach [:abr]]

Comment on attachment 8435052 [details] [diff] [review]
Update license.html for Loop-related third-party licenses

Fixing path on OpenTok license

Comment 6

[Maire Reavy [:mreavy]]

Hi Gerv -- Do you think you'll have time to review the licensing patch from Adam soon?  We'd like to land Loop-Desktop in Nightly shortly after Monday's uplift (either late Monday or early Tuesday).  Thanks.

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 8435052 [details] [diff] [review]
Update license.html for Loop-related third-party licenses

r=gerv if you need to get this landed. However, you should remove the ifdefs. There's a disclaimer at the top which says that depending on build options, not all these licenses will apply. Because if that, we don't make license inclusion conditional.

Gerv

Comment 8

[Gervase Markham [:gerv]]

One further thing: minified JS code should not be in the tree without its corresponding source. Please make sure that gets checked in as well when you land Loop. (It is not required, by me at least, that the code be reminified by everyone building the source, although you should explain how it's done, either with a Makefile or a README.)

Gerv

Comment 9

[Adam Roach [:abr]]

https://hg.mozilla.org/projects/elm/rev/606ef4899d6f

Comment 10

[Adam Roach [:abr]]

(In reply to Gervase Markham [:gerv] from comment #8)
> One further thing: minified JS code should not be in the tree without its
> corresponding source. Please make sure that gets checked in as well when you
> land Loop. (It is not required, by me at least, that the code be reminified
> by everyone building the source, although you should explain how it's done,
> either with a Makefile or a README.)

I'll fix this in another bug. Thanks for the pointer. (Getting unminified code out of the sjcl build system wasn't immediately obvious, but I have it working now).

Comment 11

[Adam Roach [:abr]]

Resolved, with #ifdef guards removed.

Comment 13

[Adam Roach [:abr]]

(In reply to Adam Roach [:abr] from comment #10)

> I'll fix this in another bug. Thanks for the pointer. (Getting unminified
> code out of the sjcl build system wasn't immediately obvious, but I have it
> working now).

See Bug 1022772.

Comment 14

[Mark Banner (:standard8)]

https://hg.mozilla.org/mozilla-central/rev/606ef4899d6f

Comment 15

[u279076]

Verified fixed in the latest Nightly.