1020721 - [Midori][Language][Marketplace][Greek]The prompt messages were not translated in Greek.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[sync-1]

Firefox OS v1.3
 AU_LINUX_GECKO_B2G_JB_3.2.01.03.00.112.301
 Mozilla build ID:20140422024003
 
 DEFECT DESCRIPTION:
  [Language][Marketplace][Greek]The prompt messages were not translated in Greek.
  REPRODUCING PROCEDURES:
  Precondition:MS has no network connection
  1.Enter Marketplace->The prompt messages were not translated--K.O
 
  EXPECTED BEHAVIOUR:
  The prompt messages should be translated
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  Medium
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:
  Beetle lite FF

Comment 1

[sync-1]

Attachment: pic

Comment 2

[Lingling Zhao]

Dear Vance,

Can you notify the Marketplace developer to fix it? 
Thanks.

Comment 3

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Nicole 

Could you help to contact the developer to translate the string into Greek?

Comment 4

[Nicole Fong]

Hi Wil, can you please review this one as well and provide feedback.  Thank you!

Comment 5

[Wil Clouser [:clouserw]]

This is ours, thanks.

Comment 6

[Lingling Zhao]

Wil,

The issue still can be reproduced,can you please help to track it?

Thanks.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Greek localisers would need to update this: https://github.com/mozilla/fireplace/blob/master/yulelog/main.js#L206-L225

Wil, when we become a fully packaged app (and get rid of Yulelog), we'll need to add logic in the Fireplace that does the offline checks (if Kevin or somebody hasn't done this already).

Comment 8

[Wil Clouser [:clouserw]]

(In reply to Lingling Zhao from comment #6)
> Wil,
> 
> The issue still can be reproduced,can you please help to track it?
> 
> Thanks.

We're tracking it.

Comment 9

[Lingling Zhao]

Dears, any update on it?

Comment 10

[Wil Clouser [:clouserw]]

(In reply to Lingling Zhao from comment #9)
> Dears, any update on it?

We're waiting on QA to test our packaged app, then we can localize this and push out a new packaged app.

Comment 11

[Lingling Zhao]

Dear wil,

The issue can be reproduced, do you have any update?

Comment 12

[Lingling Zhao]

Dear wil,

Do you have any update?

Comment 13

[Wil Clouser [:clouserw]]

This issue is blocked on us becoming a packaged app.  See the blocked bug above for a list of bugs which need to be closed before this can be resolved.

Comment 14

[Lingling Zhao]

Dears,

It seems that it will take long time to add all the needed tranlations for a packaged app. In our side we are blocked by this special bug in this PR, could you please add the Greek translations in the promp message first?

Comment 15

[Lingling Zhao]

Dears, 

any update on this issue?

Comment 16

[Christopher Van Wiemeersch [:cvan]]

(In reply to Lingling Zhao from comment #15)
> Dears, 
> 
> any update on this issue?

Wil mentioned in comment 13 to watch bug 897156 for updates.

We will become a packaged app in the next few weeks. Can the four strings wait until then? At that point, the new strings in the packaged app will also be localised in every supported language (not just these ones: https://github.com/mozilla/fireplace/blob/master/yulelog/main.js#L206-L225). If in fact this is absolutely crucial, then someone needs to localise these strings in Greek:

- Sorry, you need to be online to access the Marketplace.
- Sorry, your device clock appears to be incorrectly set.
- Please set today's date and time in your device settings to access the Marketplace.
- Try again

Comment 17

[Lingling Zhao]

As I mentioned in comment 14, it is a block PR in our side and is crucial. Could you please find someone to localise the strings in Greek, and update the release?

Thanks.

Comment 18

[[e-mail]]

Now that date checking [1] and offline checks [2] were ported from yulelog I think this should no longer be an issue.

[1] bug 1044230
[2] bug 1044225

Comment 19

[Andy McKay]

This localisations are in the .po files, but look like they haven't been translated into Greek yet:

https://localize.mozilla.org/el/fireplace/LC_MESSAGES/translate.html#search=Sorry%2C%20you%20need%20to%20be%20online%20to%20access%20the%20Marketplace&sfields=source,target

Comment 20

[Peiying Mo [:CocoMo]]

Hi Iosif,

Could you please help with the request in comment #19?  Thank you!

Comment 21

[Iosif Psychas [:TheGallery]]

I am gonna work on this as soon as I can. It'll probably take a week since I've got so much stuff to translate already.

Comment 22

[Iosif Psychas [:TheGallery]]

I've updated and committed the l10n file for Fireplace (and most of the other Marketplace projects)

Comment 23

[Peiying Mo [:CocoMo]]

Thank you Iosif.

Comment 24

[Andy McKay]

Thanks all, there's now a Marketplace package update that will fix 1.3 devices when they update their Marketplace app and its been added to Gaia for 2.1.