1021364 - Tabs tray does not update strings on locale change

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: German sync, Korean browser

The options menu does not appear to have such appear issues.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Michael Comella (:mcomella) from comment #0)
> Created attachment 8435385 [details]
> German sync, Korean browser
> 
> The options menu does not appear to have such appear issues.

What are the other panel texts like?  Is there a string in the other panels?  I'm guessing that we're not invalidating the panels when as part of the "chrome refresh".

Comment 2

[Richard Newman [:rnewman]]

Typically, you should do one of these things:

* Reinflate the views.
* Call onConfigurationChanged and hope it handles the change.
* Manually set strings.

How do you know when to do these things? BrowserApp must tell you (from onLocale*).

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Nick Alexander :nalexander from comment #1)
> What are the other panel texts like?  Is there a string in the other panels?

The RemoteTabsList has the text "Last synced:" which is the original locale for a split second, but then changes to the new locale. There is no other text on the other panels (until bug 1002303 lands) with the caveat that the open tabs do not refresh (e.g. about:home, which stays "Nightly Home" instead of switching to "Nightly 홈" (for Korean)) - see bug 963882.

Comment 4

[Richard Newman [:rnewman]]

(In reply to Michael Comella (:mcomella) from comment #3)

> with the caveat that the
> open tabs do not refresh (e.g. about:home, which stays "Nightly Home"
> instead of switching to "Nightly 홈" (for Korean)) - see bug 963882.

I just WONTFIXed that. We don't care enough.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Richard, is this something you'd like to mentor?

Comment 6

[Nick Alexander :nalexander [he/him]]

I expect this to be FIXED WORKSFORME after Bug 1014994 lands.

Comment 7

[Richard Newman [:rnewman]]

Michael, can you close this if it was indeed fixed?

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: English private tabs, korean browser

Seems this is just a problem with the tabs tray in general.

Comment 9

[Zibi Braniecki [:zbraniecki][:gandalf]]

I cannot reproduce it in today's nightly.

Michael, can you verify that this bug still exists for you?

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I can no longer reproduce.

Perhaps this is fixed by bug 1378501 & friends (dupe?)?

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #10)
> I can no longer reproduce.

However, I found a new locale problem with the context menu on this screen: bug 1399573.