1022573 - Australis widget icons lack contrast when using High Contrast mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P4)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

The widget icons added for Australis lack adequate contrast when using High Contrast mode. This is especially true of the cut/copy/paste and zoom controls. See attached screenshot. We should have black versions and white versions, for black-on-white and white-on-black high Contrast modes respectively.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot

Comment 2

[Dão Gottwald [:dao]]

(In reply to Blair McBride [:Unfocused] from comment #0)
> The widget icons added for Australis lack adequate contrast when using High
> Contrast mode. This is especially true of the cut/copy/paste and zoom
> controls. See attached screenshot.

The zoom controls have the same contrast as other items in your screenshot. Cut/copy/paste are probably just disabled.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 5

[Mike Conley (:mconley) (:⚙️)]

This looks okay, but I've pushed a mozscreenshot job to closer inspection:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f47847a40c78

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8778531 [details] [diff] [review]
patch v2

Review of attachment 8778531 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay - the screenshots stuff didn't end up working out on automation, so I did a bunch of manual testing locally. This looks good to me! Thanks for your work on this stuff, Dao.

::: browser/themes/shared/menupanel.inc.css
@@ -24,5 @@
>    toolbarpaletteitem[place="palette"] > #bookmarks-menu-button {
>      -moz-image-region: rect(0px, 192px, 32px, 160px);
>    }
>  
> -  #bookmarks-menu-button[cui-areatype="menu-panel"][panel-multiview-anchor=true] {

It's nice that we can get rid of these and do CSS filtering instead. Perhaps we should file a bug to remove the unnecessary glyphs from menuPanel.png and [e-mail] as well?

Comment 7

[Dão Gottwald [:dao]]

(In reply to Mike Conley (:mconley) - (Needinfo me!) from comment #6)
> > -  #bookmarks-menu-button[cui-areatype="menu-panel"][panel-multiview-anchor=true] {
> 
> It's nice that we can get rid of these and do CSS filtering instead. Perhaps
> we should file a bug to remove the unnecessary glyphs from menuPanel.png and
> [e-mail] as well?

This patch actually does that already.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

(In reply to Dão Gottwald [:dao] from comment #7)
> (In reply to Mike Conley (:mconley) - (Needinfo me!) from comment #6)
> > > -  #bookmarks-menu-button[cui-areatype="menu-panel"][panel-multiview-anchor=true] {
> > 
> > It's nice that we can get rid of these and do CSS filtering instead. Perhaps
> > we should file a bug to remove the unnecessary glyphs from menuPanel.png and
> > [e-mail] as well?
> 
> This patch actually does that already.

My apologies - I hadn't checked the patch, only the diff. Thanks, and carry on!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6af49d08884d
Make icons in the app menu work better with high-contrast settings. r=mconley

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6af49d08884d

Comment 11

[Azmina]

I have reproduced this bug with Nightly 32.0a1 (2014-06-09) on Windows 8.1 , 64Bit!

This Bug's fix is verified on Latest Nightly  51.0a1.
Build ID : 20160816030459
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160817]

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!