1026608 - Delete button on main toolbar doesn't always change to "Undelete" when toggled from keyboard or header pane

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[rsx11m]

That's a fringe use case but a bug anyway:

 - Configuration:
   - Set up Thunderbird for an IMAP account
   - Select "Mark as deleted" in Server Settings
   - Put the "Delete" button on the main toolbar

 - Go to the last message of your Inbox or any other IMAP folder
   (that's to prevent it to moving to the next message after delete)

 - Click "Delete" in the header-pane toolbar, OR
 - hit the "Delete" key of your keyboard

Expected result:

 - Main toolbar button changes to "Undelete" per bug 234665

Actual result:

 - Main toolbar remains with "Delete" label

 - On top, toggle "Delete" status again (not from the main toolbar),
   observe that the toolbar button changes but to the /opposite/ state

The label is correct when /first/ entering a marked-as-deleted message (see bug 801264 though, which may be related).

BTW: The header-pane "Delete" button stays as such and doesn't change to "Undelete" with the message stricken out, that's on purpose?
 
Observed while testing 31.0b1 on Linux, but also seen with 24.6.0 release and on Windows, so this has been in there for a while.

SeaMonkey 2.26.1 does not show the issue, thus Thunderbird-specific.

Comment 1

[:aceman]

Attachment: patch

This works for me. It looks like not all of the changes are really needed to fix this bug, but I added it to all delete paths where it was missing to have some consistency.

This does not fix the message header button, but that one does not have the infrastructure for Delete/Undelete as the toolbar button has.

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/comm-central/rev/eaa66c0f3d6f

Comment 3

[rsx11m]

Is this wanted for the new 31.x branch?
Seems to be easy enough as a patch...

Comment 4

[Mark Banner (:standard8)]

Please can someone request relevant approvals (beta & esr?) with appropriate risk statements.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8443902 [details] [diff] [review]
patch

Ok, I normally like a bit of analysis, but this seems simple enough we can just move forward on. Lets get this onto aurora and beta for some additional testing.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8443902 [details] [diff] [review]
patch

This already landed in 33.

Comment 7

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-beta/rev/61a4a1b68d42

Comment 8

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/fee0aaa0392a