1028027 - cloning a bug pre-fills mentors with "---" instead of an empty value

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

cloning a bug pre-fills mentors with "---" instead of an empty value.
this results in a user search for "---" when the bug is submitted.

Comment 1

[David Lawrence [:dkl]]

Attachment: 1028027_1.patch

I could not reproduce the '---' issue at all when trying to clone a bug in different ways. But this patch does add the ability to clone a bug's mentor values which was lacking before. So feel free to change the bug summary unless you can provide a more detailed way to reproduce the original issue or if this patch solves the issue anyway.

Thanks
dkl

Comment 2

[:glob ✱]

this is easy to reproduce on production: https://bugzilla.mozilla.org/enter_bug.cgi?format=__default__&cloned_bug_id=1028027&product=bugzilla.mozilla.org&component=General

i don't see this on my dev system, even when using the production branch.

Comment 3

[:glob ✱]

Comment on attachment 8443494 [details] [diff] [review]
1028027_1.patch

Review of attachment 8443494 [details] [diff] [review]:
-----------------------------------------------------------------

can you please file a new bug for your patch as it isn't related to this issue.

::: enter_bug.cgi
@@ +297,5 @@
>      # BMO Bug 1019747
>      $vars->{'cloned_bug'} = $cloned_bug;
>  
> +    # BMO Allow mentors to be cloned as well
> +    #$vars->{'bug_mentors'} = join(', ', map { $_->login } @{ $cloned_bug->mentors });

this code is commented out; not sure if that's on purpose or not.

Comment 4

[:glob ✱]

(In reply to Byron Jones ‹:glob› from comment #3)
> can you please file a new bug for your patch as it isn't related to this
> issue.

bug 1029429

Comment 6

[:glob ✱]

this is happening because we don't set the 'value' variable when calling userselect.
it inherits the previous value, which on production is the new cf_fx_points field.

Comment 7

[:glob ✱]

after discussion with dkl we realised his patch here actually resolves this issue.
reassigning back to him for an updated patch.

Comment 9

[David Lawrence [:dkl]]

Attachment: 1028027_2.patch

Fixed commented code and added cf_fx_points locally to test and worked well.

Comment 10

[:glob ✱]

Comment on attachment 8446171 [details] [diff] [review]
1028027_2.patch

Review of attachment 8446171 [details] [diff] [review]:
-----------------------------------------------------------------

this patch is perfect for cloning bugs.
we also need to read the mentors from the query_string to fix the bookmark-template issue from bug 1029429

Comment 11

[David Lawrence [:dkl]]

Attachment: 1028027_3.patch

Ugh sorry left that out. New patch.

Comment 12

[:glob ✱]

Comment on attachment 8446571 [details] [diff] [review]
1028027_3.patch

Review of attachment 8446571 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 13

[Ed Morley [:emorley]]

Will this also fix using "remember values as template", which currently generates a bookmark that has "---" in the mentors field?

Comment 14

[David Lawrence [:dkl]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #13)
> Will this also fix using "remember values as template", which currently
> generates a bookmark that has "---" in the mentors field?

It will for future bookmarks but you will need to fix your currently stored bookmarks.

Comment 15

[David Lawrence [:dkl]]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   e2b27e4..14adc0f  master -> master