1036592 - Thunderbird does not respect "Skip Integration"

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[BugzillaJade.5.JadeNB]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

(On Mac OS Mavericks.  This looks like it is related to https://bugzilla.mozilla.org/show_bug.cgi?id=476426, but that is marked resolved since long ago, and this is happening with a days-old download.)

1.  On first opening Thunderbird,  at the prompt "Use Thunderbird as the default client for:", uncheck "E-mail" and click "Skip Integration"
2.  Leave "Always perform this check when starting Thunderbird" unchecked
2.  Re-open Thunderbird


Actual results:

1.  On re-opening, Thunderbird again prompts "Use Thunderbird as the default client for:"


Expected results:

1.  Integration prompt should appear only once

Comment 1

[:aceman]

This works fine for me on Win XP (TB 33). There seem to be no relevant changes to the dialog between TB 24 and 33.

The dialog intentionally saves the state of "Always perform this check when starting Thunderbird" checkbox whatever button you click. But the checks for E-mail/News/RSS are stored only if "Set as Default" is clicked.

Josiah, can you please test this on OS X?

Comment 2

[Jerry Baker]

I experience this issue with Tbird 24.6 on Windows 7.

Comment 3

[Jerry Baker]

Verified mail.shell.checkDefaultClient is false in prefs.

Comment 4

[Jerry Baker]

Adding

user_pref("mail.winsearch.firstRunDone", true);
user_pref("mail.winsearch.enable", false);

to prefs.js eliminates the prompt.

Comment 5

[:aceman]

Jerry, did you see the checkbox "Allow Windows Search to search messages" in the dialog?

Comment 6

[:aceman]

The same question is valid for the reporter.

Comment 7

[Jerry Baker]

I do see it, but I do not wish to check it. I don't want Windows indexing my mailbox.

Comment 8

[:aceman]

I think if you click "Skip integration" we do not save the flag that we already shown the Search options. So that causes TB to show the dialog again at each start.
To properly save all the settings, you would have to click the "set as default" button. Just uncheck anything (mail/news) you DO NOT want to set as default before that.

The Skip Integration button is quite strange, it does save the "do not check again" checkbox, but not the Windows search checkbox. It is problematic and we are discussing it in bug 841533.

Comment 9

[BugzillaJade.5.JadeNB]

(In reply to :aceman from comment #6)
> The same question is valid for the reporter.

@:aceman, I don't think that the question is relevant for me, since I am using OS X, not Windows.  There is an "Allow Spotlight to search messages" button, but, like @JerryBaker, I do not wish to check it.

Comment 10

[BugzillaJade.5.JadeNB]

@JerryBaker's solution in comment #4 works for me, too.

Comment 11

[:aceman]

(In reply to BugzillaJade.5.JadeNB from comment #9)
> @:aceman, I don't think that the question is relevant for me, since I am
> using OS X, not Windows.  There is an "Allow Spotlight to search messages"
> button, but, like @JerryBaker, I do not wish to check it.
It is, because it does not matter which search engine is offered, just that any one is there (otherwise the whole option is hidden).

So thanks for confirmation, I think I now know what is going on.

Comment 13

[:aceman]

Attachment: patch

So, let's save SearchIntergration.firstRunDone regardless which button is clicked. And also disable search when the user clicked Skip Integration, regardless of the state of the checkbox. This seems to fix the biggest problem as reported and could go into branch too.

A better fix/redesign will be done in bug 841533.

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 8492656 [details] [diff] [review]
patch

Review of attachment 8492656 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 16

[Nashmarkt]

When is this bug expected to be fixed? Can you imagine how annoying it is to click "Skip Integration" every time you launch TB? 
BTW I would love to have TB as my default email app (like I do on my home Mac) but I am am using it here on my Work computer and I have to run Outlook as my default email for work purposes.

Comment 17

[:aceman]

Relatively soon, we are just waiting for the ui-review here. Which either will be trivial, or will completely break us and propose some radically different solution. But that one should be saved for bug 841533 :)

Comment 18

[:aceman]

If you do not want to click the dialog till then, use the workaround from comment 4.

Comment 19

[Nashmarkt]

I added this to prefs.js. Still the same problem. TB 31.1.2 on Mac OS 10.9.5
user_pref("mail.winsearch.firstRunDone", true);
user_pref("mail.winsearch.enable", false);

Comment 20

[:aceman]

Yeah, sorry, for Mac the prefs are:
user_pref("mail.spotlight.enable", false);
user_pref("mail.spotlight.firstRunDone", true);

Comment 21

[:aceman]

Thanks.

Comment 22

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/2f79b0b939ed

Comment 23

[Patrick Cloke [:clokep]]

I apparently grabbed the wrong file and modified configure.in before amending this commit, https://hg.mozilla.org/comm-central/rev/6f0777b07770 backs out the unrelated part. Sorry about that.

Comment 24

[:aceman]

Comment on attachment 8492656 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 476426
User impact if declined: On Windows platforms that have Search support (probably Vista+)) and the user does not want TB to be the default client, the Integration dialog is popping up at each start.
Testing completed (on c-c, etc.): trunk
Risk to taking this patch (and alternatives if risky):

Comment 26

[Mark Banner (:standard8)]

Comment on attachment 8492656 [details] [diff] [review]
patch

[Triage Comment]
This should land on aurora & beta first.

Comment 27

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/1f5c6fd5bf65
https://hg.mozilla.org/releases/comm-beta/rev/ea0299069557

Comment 28

[Mark Banner (:standard8)]

For the additional backout

https://hg.mozilla.org/releases/comm-aurora/rev/19390ffe1de1
https://hg.mozilla.org/releases/comm-beta/rev/56fe4fac57d0

Comment 29

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/2105d6cb88e1

Comment 30

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr31/rev/3507d510b178