1037341 - Update pin and block with new icons

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

Attachment: wip screenshot

dcrobot's ui spec has new round buttons that are in the top-right corner of a tile.

Comment 1

[Aaron]

Label for a pinned tiles should be Segoe UI, Negreta cursiva, 14 pixels, HEX = D0021B

Currently, it is not italicized.

Comment 2

[Ed Lee :Mardak]

Latest mockups have pin/block both at top corners as they were before.

Comment 3

[Ed Lee :Mardak]

Attachment: v1

Comment 4

[Ed Lee :Mardak]

Attachment: v1.1

Removed doctype per bug 1023655.

Comment 5

[Aaron]

Excellent. Can we add 5 pixels between the tile and it's label?

Comment 6

[Ed Lee :Mardak]

Attachment: v1.1 screenshot @layout.css.devPixelsPerPx=4

Seems like svg + zoom/hidpi is working correctly

Comment 7

[Ed Lee :Mardak]

(In reply to Aaron from comment #5)
> Excellent. Can we add 5 pixels between the tile and it's label?
For this bug? It's not really related to the pin and block icons. Also, 5px lower would make it closer to the tile below it than the tile it's actually associated with. And increasing the spacing between tiles gets closer to making the default number of visible rows 2 for most users.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8461712 [details] [diff] [review]
v1.1

Review of attachment 8461712 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/newtab/newTab.inc.css
@@ +205,5 @@
>  
>  .newtab-control-sponsored {
> +  width: 24px;
> +  height: 24px;
> +  background-image: url(chrome://browser/skin/newtab/controls.png);

This should use [e-mail] for 2x DPI, like it currently does, right?  r+ with that change, or let me know if I'm wrong.

It looks like .newtab-control-sponsored is the only thing left that uses controls[@2x].png.  Are there plans for that?  I think I saw somewhere it's going to be removed?

Comment 9

[Ed Lee :Mardak]

Attachment: for checkin

(In reply to Drew Willcoxon :adw from comment #8)
> Comment on attachment 8461712 [details] [diff] [review]
> ::: browser/themes/shared/newtab/newTab.inc.css
> >  .newtab-control-sponsored {
> > +  background-image: url(chrome://browser/skin/newtab/controls.png);
> This should use [e-mail] for 2x DPI, like it currently does, right? 
> r+ with that change, or let me know if I'm wrong.
Indeed. Good catch! Added appropriate styling.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8f7aa126566d

Comment 11

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 34.0a1 (buildID: 20140730030201).

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Uplift has been managed in bug 1057602

Comment 13

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ea4d28eac435

Comment 14

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:33.0) Gecko/20100101 Firefox/33.0
Mozilla/5.0 (X11; Linux i686; rv:33.0) Gecko/20100101 Firefox/33.0

Verified fixed on Windows 7 64bit, Mac OS X 10.8.5 and Ubuntu 14.04 32bit using latest Aurora, build ID: 20140828004002.