1037091 - Add gear button with doorhanger configuration of newtab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

From the prototype: http://bg61zt.axshare.com/new_tab.html

There'll need to be a gear icon to customize the new tab page with presets:
- enhanced
- classic
- blank

Where these presets toggle various show/hide customizations for the page:
- enhanced images
- search box
- tiles
- messaging/explanation area

enhanced = all
classic = search + tiles
blank = none

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8461258 [details] [diff] [review]
v1

Review of attachment 8461258 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, the only thing is that I think "customize" would be a better name for everything than "gear," but it's a nit, so feel free to ignore.

Comment 3

[Ed Lee :Mardak]

This patch uses the svg added in bug 1037341.

Comment 4

[Ed Lee :Mardak]

Attachment: for checkin

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/999c74d2ab23

Comment 6

[Mikel]

Can anyone confirm that the gear button changes sizes on new tab openings?
https://bugzilla.mozilla.org/show_bug.cgi?id=1044570

Comment 7

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I've verified this using the latest Firefox 34 Nightly build (20140804030205) on: Win 7 x64, Win 8 x64, Win 8.1 x64, Ubuntu 12.04 x64, Mac OS X 10.9.4.

I was able to verify that the following work as expected:
- gear icon displays in the top right corner of the New Tab page, and has an alternative image when hovered/selected
- gear icon opens a list with options: Enhanced, Classic (default), Blank
- selecting Enhanced will set the following:
     * browser.newtabpage.enabled=true
     * browser.newtabpage.enhanced=true
     * enhanced history tiles will display in all New Tabs for *.mozilla.org (bug 1042204 comment 6)
- selecting Classic will set the following:
     * browser.newtabpage.enabled=true
     * browser.newtabpage.enhanced=false
     * non-enhanced regular history tiles will display in all New Tabs for *.mozilla.org (bug 1042204 comment 6)
- selecting Blank will set the following:
     * browser.newtabpage.enabled=false
     * browser.newtabpage.enhanced=false/true (depends if switched from Enhanced or Classic)
     * all New Tab pages will display empty (with just the gear icon visible and accessible)
- transitions between the 3 options work fine

Potential issues:
1. For now I see that there's not much difference between Enhanced and Classic modes - the only difference is that in Enhanced mode we display enhanced history tiles with a rollover picture on hover (see bug 1042204 comment 6). This means that the "messaging/explanation area" is not seen... let me know if this is an issue (I'm guessing it's not or will not be implemented?).
2. Gear icon is invisible in High Contrast modes (white, black, color) in Windows - see attached image
3. Gear icon looks rather blurry while in hovered/selected state - see attached image
4. Can open/dismiss list of options via keyboard, but cannot select one of the options in the list via keyboard

(In reply to Mikel from comment #6)
> Can anyone confirm that the gear button changes sizes on new tab openings?
> https://bugzilla.mozilla.org/show_bug.cgi?id=1044570
I've tried to reproduce this in all 5 operating systems that I've used, but was unsuccessful. I could not get the gear icon to change size even after quickly opening 60-70 New Tabs.

Ed, can you review what was tested above, and especially the list of potential issues, and let me know whether I should file them separately (and close this) or reopen this issue.

Comment 8

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: blurry_gear_icon.png

Comment 9

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Attachment: newtab_gear_icon_high_contrast.png

Comment 10

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #7)
> 3. Gear icon looks rather blurry while in hovered/selected state - see
> attached image

Looks like tjis is bug 1046693.

Comment 11

[Ed Lee :Mardak]

(In reply to Florin Mezei, QA (:FlorinMezei) from comment #7)
> 1. For now I see that there's not much difference between Enhanced and
> Classic modes
Yup. For now it's just the enhancement of history and there's not many history tiles that are getting enhanced right now.

> 2. Gear icon is invisible in High Contrast modes (white, black, color) in
> Windows - see attached image
Please file a followup.

> 3. Gear icon looks rather blurry while in hovered/selected state - see
> attached image
Bug 1046693.

> 4. Can open/dismiss list of options via keyboard, but cannot select one of
> the options in the list via keyboard
A followup for this too. Bug 1044537 is related to the menu items but not about keyboard access. Also, I would think gear menu item related issues should be the same with the search engine selection menu.

Comment 12

[Drew Willcoxon :adw]

(In reply to Ed Lee :Mardak from comment #11)
> > 4. Can open/dismiss list of options via keyboard, but cannot select one of
> > the options in the list via keyboard
> A followup for this too. Bug 1044537 is related to the menu items but not
> about keyboard access. Also, I would think gear menu item related issues
> should be the same with the search engine selection menu.

Yes, please file individual follow-ups for each menu.

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Ed Lee :Mardak from comment #11)
> (In reply to Florin Mezei, QA (:FlorinMezei) from comment #7)
> > 2. Gear icon is invisible in High Contrast modes (white, black, color) in
> > Windows - see attached image
> Please file a followup.
Added bug 1051861.

> > 4. Can open/dismiss list of options via keyboard, but cannot select one of
> > the options in the list via keyboard
> A followup for this too. Bug 1044537 is related to the menu items but not
> about keyboard access. Also, I would think gear menu item related issues
> should be the same with the search engine selection menu.
Added bug 1051865 for the gear icon, and bug 1051873 for the Search Provider button.

Marking this as verified since follow up bugs are tracked separately, and have been added to the backlog.

Comment 14

[Ed Lee :Mardak]

To land this for aurora, we need to not change strings. This means the functionality for aurora non-en-US users will see a gear icon that toggles the newtab page.

Comment 15

[Ed Lee :Mardak]

Attachment: for aurora

For uplift to aurora, we want to avoid string changes in the properties/dtd.

Comment 16

[Ed Lee :Mardak]

Attachment: aurora delta

This patch is on top of the one landed in m-c, but when landing this patch for aurora, it'll be squashed into the same commit so there's no churn of locales files.

Comment 17

[Ed Lee :Mardak]

Attachment: aurora delta

Here's a patch on top of what landed in m-c but to make it string-freeze-friendly for aurora uplift.

Comment 18

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ec043dac15da

Comment 19

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on Windows 7 64bit, Mac OS X 10.8.5 and Ubuntu 14.04 32bit using latest Aurora, build ID: 20140828004002.