Closed Bug 1038323 Opened 6 years ago Closed 6 years ago
Clear Recent History menuitem doesn't have a keyboard shortcut
That's Ctrl+Shift+Del in both Firefox and SeaMonkey. http://mxr.mozilla.org/comm-central/search?string=sanitizeHistory&find=mail/ http://mxr.mozilla.org/comm-central/search?string="key_sanitize"&find=browser/ Thanks to Bozz for reporting this.
This adds the keyboard shortcut Ctrl+Shift+Del for Windows and Linux as desired. I'm not sure about Mac, which has Ctrl+Shift+Back instead. The respective code is copied from bug 342743 attachment 239977 [details] [diff] [review] and seems to work this way in Firefox (apparently just adding "_mac" does the trick?), but I don't have a Mac myself and thus can't test it. While there, I've wrapped some overly long lines in the vicinity as well. Does this need ui-review too or is it simple enough for a single review?
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #8455710 - Flags: review?(mkmelin+mozilla)
Ok, now I get it. Removing the #ifdef XP_MACOSX clause makes Ctrl+Shift+Back work on Windows as well. That id attribute is only of interest to show the shortcut in the menu using the "key" attribute. Thus, on a Mac, either Ctrl+Shift+Del or Ctrl+Shift+Back can be used to open the sanitize dialog, but only Ctrl+Shift+Del is presented as a keyboard shortcut in the menus.
Comment on attachment 8455710 [details] [diff] [review] Proposed fix Review of attachment 8455710 [details] [diff] [review]: ----------------------------------------------------------------- LGTM! r=mkmelin I don't think this needs special ui-r, especially given it's just copying firefox behavior ::: mail/base/content/mailWindowOverlay.xul @@ +510,5 @@ > <!-- Tools Keys --> > + <key id="key_searchMail" > + key="&searchMailCmd.key;" > + oncommand="goDoCommand('cmd_search')" > + modifiers="accel, shift"/> while touching, please remove the space between comma and shift
Attachment #8455710 - Flags: review?(mkmelin+mozilla) → review+
Done, push for comm-central please.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 34.0
You need to log in before you can comment on or make changes to this bug.