1038323 - Clear Recent History menuitem doesn't have a keyboard shortcut

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[rsx11m]

That's Ctrl+Shift+Del in both Firefox and SeaMonkey.

http://mxr.mozilla.org/comm-central/search?string=sanitizeHistory&find=mail/
http://mxr.mozilla.org/comm-central/search?string="key_sanitize"&find=browser/

Thanks to Bozz for reporting this.

Comment 1

[rsx11m]

Attachment: Proposed fix

This adds the keyboard shortcut Ctrl+Shift+Del for Windows and Linux as desired. I'm not sure about Mac, which has Ctrl+Shift+Back instead. The respective code is copied from bug 342743 attachment 239977 [details] [diff] [review] and seems to work this way in Firefox (apparently just adding "_mac" does the trick?), but I don't have a Mac myself and thus can't test it.

While there, I've wrapped some overly long lines in the vicinity as well.

Does this need ui-review too or is it simple enough for a single review?

Comment 2

[rsx11m]

Ok, now I get it. Removing the #ifdef XP_MACOSX clause makes Ctrl+Shift+Back work on Windows as well. That id attribute is only of interest to show the shortcut in the menu using the "key" attribute.

Thus, on a Mac, either Ctrl+Shift+Del or Ctrl+Shift+Back can be used to open the sanitize dialog, but only Ctrl+Shift+Del is presented as a keyboard shortcut in the menus.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8455710 [details] [diff] [review]
Proposed fix

Review of attachment 8455710 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin
I don't think this needs special ui-r, especially given it's just copying firefox behavior

::: mail/base/content/mailWindowOverlay.xul
@@ +510,5 @@
>    <!-- Tools Keys -->
> +  <key id="key_searchMail"
> +       key="&searchMailCmd.key;"
> +       oncommand="goDoCommand('cmd_search')"
> +       modifiers="accel, shift"/>

while touching, please remove the space between comma and shift

Comment 4

[rsx11m]

Attachment: Patch for check-in

Done, push for comm-central please.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/4f2a2efc1c82