1042939 - Alarms, periodic sync, and notifications refactor

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

The parts of the calendar codebase which interact with the alarms and notifications apis were mostly tacked on and have suffered from lots of correctness issues. This bug tracks some of those issues and efforts to clean up those bits of the app.

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21827

Hey Miller + James,

These are some (currently not unit tested, though somewhat marionette tested) motions to clean up calendar interactions with the alarms and notifications apis. Bikeshed!

Comment 2

[James Lal [:lightsofapollo]]

Comment on attachment 8461109 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21827

Took a quick skim nothing obviously wrong I see I will leave the rest up to miller

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8461109 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21827

cleaning the ?feedback flag. there are still some comments on github that needs to be addressed before a full code review.

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25282

Updated after amd conversion! Hopefully we can get this landed so that it's a bit clearer what's going on with the interactions between calendar and the alarms api.

Comment 5

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8508376 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25282

Code looks way cleaner than before. Now we can easily understand what is going on. Good work!

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/3c901411771b4854c07c300ebcded0a793c625ed landed on master