1043344 - Move libraries and programs build to the compile tier

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

With all the knowledge from bug 1036894, and a few temporary hacks, it is possible to get a full compilation/linkage build in the compile tier.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move libraries and programs build to the compile tier

This has the nice side effect of having some things build while libxul links. This however has the caveat of making js standalone clobber builds slightly slower because building js/src now waits for icu, but with bug 1036894 (and this one, actually), it's possible to work around this in many different ways, but I'd rather not wait on figuring what to choose. There are also further improvements I'd like to make that would allow building even more things while libxul links that would make js/src wait less for intl/icu.

https://tbpl.mozilla.org/?tree=Try&rev=aa249f1b56a1

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8461498 [details] [diff] [review]
Move libraries and programs build to the compile tier

Review of attachment 8461498 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/target_binaries.mk
@@ +22,5 @@
>  
>  ifneq (,$(strip $(PROGRAM)$(SIMPLE_PROGRAMS)))
>  PROGRAMS_EXECUTABLES = $(SIMPLE_PROGRAMS) $(PROGRAM)
>  PROGRAMS_DEST ?= $(FINAL_TARGET)
> +PROGRAMS_TARGET := binaries libs target

Note I'm not removing the existing targets as a safety net.

::: config/recurse.mk
@@ +193,5 @@
>  	$$(LOOP_OVER_DIRS)
>  
>  endef
>  
> +$(foreach subtier,export binaries libs tools,$(eval $(call CREATE_SUBTIER_TRAVERSAL_RULE,$(subtier))))

This removes recursion for make -C foo compile, which is not a good thing to do now, and wouldn't be much better after this patch.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Move libraries and programs build to the compile tier

https://tbpl.mozilla.org/?tree=Try&rev=e70e5ba994e6

Comment 4

[Mike Hommey [:glandium]]

Attachment: Move libraries and programs build to the compile tier

I *will* get this right. (android reds were a problem with bug 1043351 in the queue, and windows red is a race condition because of the removal of the config/export dependency that I'm now readding)
https://tbpl.mozilla.org/?tree=Try&rev=640cbf58ff6c

Comment 5

[Mike Hommey [:glandium]]

Attachment: Move libraries and programs build to the compile tier

Aaand with the toplevel Makefile.in change corresponding to last rules.mk change.

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8461564 [details] [diff] [review]
Move libraries and programs build to the compile tier

Review of attachment 8461564 [details] [diff] [review]:
-----------------------------------------------------------------

I am anxiously awaiting what you decide to do with all the remaining gunk in the now-emptier-and-painfully-slower-than-ever libs tier. I'm sure it will be awesome.

::: python/mozbuild/mozbuild/backend/recursivemake.py
@@ +716,5 @@
>                  self._create_makefile(obj, stub=stub)
> +                with open(obj.output_path) as fh:
> +                    content = fh.read()
> +                    for trigger, targets in self._triggers.items():
> +                        if trigger.encode('ascii') in content:

The hacks, they burn!

I can only assume from other comments in this patch that follow-ups are already in your head.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0300f04572b6

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0300f04572b6