Closed Bug 1049800 Opened 5 years ago Closed 5 years ago

Package extensions into xpis

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.31

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

Details

Attachments

(2 files)

Once fixes on bug 1047924 and bug 1047981 land, we can now take advantage of this and package extensions into the right locations.
Attachment #8468668 - Flags: review?(bugspam.Callek)
See bug 1047924 comment#4 for why I don't understand this change.
Blocks: 1050992
(In reply to neil@parkwaycc.co.uk from comment #1)
> See bug 1047924 comment#4 for why I don't understand this change.

I would say the m-c equiv seems to be missing for that piece, and I'm not sure I comprehend the necessity of a change on that side.
Comment on attachment 8468668 [details] [diff] [review]
Package xpis where they are [Checked in: Comment 6]

Review of attachment 8468668 [details] [diff] [review]:
-----------------------------------------------------------------

something about this looks wrong, can you please provide a local build log, snipped for ~ these commands (+ a slight bit of context)  (in a -j1 make invoke would be ideal, so I don't get confusion in logs due to parallelism)

Once I have that to go on, this will be a lot easier for me to review.

::: suite/app/Makefile.in
@@ +125,4 @@
>  # NOTE: This is a hack to run this at the end of compilation, would be nicer
>  # if this was done right away for built-in extensions in omnijar mode.
>  # Listed extension GUIDs:
> +# 972ce4c6-... Classic Theme, 59c81df5-... ChatZilla, e2fda1a4-... Lightning

This piece of adjusted comment is wrong, you're no longer losting extension GUIDs.
Flags: needinfo?(iann_bugzilla)
Attached file sm_packaging.log
Flags: needinfo?(iann_bugzilla)
Comment on attachment 8468668 [details] [diff] [review]
Package xpis where they are [Checked in: Comment 6]

Review of attachment 8468668 [details] [diff] [review]:
-----------------------------------------------------------------

r+ based on log. Thanks!
Attachment #8468668 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8468668 [details] [diff] [review]
Package xpis where they are [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/ea566228448a
Attachment #8468668 - Attachment description: Package xpis where they are → Package xpis where they are [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.31
(In reply to Justin Wood (:Callek) from comment #3)
> Comment on attachment 8468668 [details] [diff] [review]
> ::: suite/app/Makefile.in
> @@ +125,4 @@
> >  # NOTE: This is a hack to run this at the end of compilation, would be nicer
> >  # if this was done right away for built-in extensions in omnijar mode.
> >  # Listed extension GUIDs:
> > +# 972ce4c6-... Classic Theme, 59c81df5-... ChatZilla, e2fda1a4-... Lightning
> 
> This piece of adjusted comment is wrong, you're no longer losting extension
> GUIDs.
Removed the last two lines of the comment on checkin.
You need to log in before you can comment on or make changes to this bug.