Closed Bug 1050683 Opened 6 years ago Closed 6 years ago

UnifiedComplete is missing nsIAutoCompleteSearchDescriptor

Categories

(Toolkit :: Places, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
mozilla34
Iteration:
34.2

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file, 1 obsolete file)

Looks like I forgot to add it, it's a very trivial oneline patch.

Marco, could you please add this to the current iteration? It will take just a few minutes. (yes, I know about the cap, no worries)
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Blocks: 1049506
Iteration: --- → 34.2
QA Whiteboard: [qa?]
Flags: firefox-backlog+
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #8470043 - Flags: review?(ttaubert)
Attachment #8470043 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/integration/fx-team/rev/c61532028ee4
QA Whiteboard: [qa?] → [qa-]
Target Milestone: --- → mozilla34
bah, clearly something is funky with the test
Attached patch patch v2Splinter Review
This has not been as trivial as I was expecting, but a good companion for a Friday night.

The test hit a race condition that cause a search to cancel itself, good to fix it. On the positive side this means the patch is doing what I was expecting, thus remove the urlbar delay.

It's currently running on Try.

https://tbpl.mozilla.org/?tree=Try&rev=8dd1240eeff
Attachment #8470343 - Flags: review?(ttaubert)
Comment on attachment 8470343 [details] [diff] [review]
patch v2

Review of attachment 8470343 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8470343 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/eae2c3cb8a19
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Duplicate of this bug: 1049506
Attachment #8470043 - Attachment is obsolete: true
Depends on: 1051777
Duplicate of this bug: 1051047
You need to log in before you can comment on or make changes to this bug.