Closed Bug 1054447 Opened 5 years ago Closed 5 years ago

[Browser] Browser Start Page Refinements

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

x86
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S3 (29aug)

People

(Reporter: epang, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

User Story

VisD: https://mozilla.box.com/s/ac65vfmuq1ywl9s2wkqc

Attachments

(2 files)

Titles of top sites should be left aligned and the stroke around top sites should be #858585 @80 opacity.
Truncation of history items is also needed, I've added this to the spec.
Blocks: 962610
Blocks: 938288
No longer blocks: browser-chrome-mvp, 962610
Blocks: rocketbar-search-mvp
No longer blocks: 938288
Component: Gaia::System::Browser Chrome → Gaia::Search
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Target Milestone: --- → 2.1 S3 (29aug)
Hey Eric! Could you run this through a ui-review. Updates:

1 - Adjusted border color to spec.
2 - Made top sites font left-aligned.
3 - Made history items truncate with ellipsis.


Question:

Should the the "Top Sites" header have borders like the history header? The spec mentions a border color and size, but I don't see it visually.
Attachment #8476449 - Flags: ui-review?(epang)
Attached file Github pull request
Comment on attachment 8476449 [details]
Implementation screenshot.png

Yes, thanks for adding in the border for top sites (i must have had the layer turned off).

Can you check one thing?  The font size and colour of the history items seem to be off.  Once this is fixed I think we should be good.  I've R+ since I'm on PTO tomorrow.

Also a side note, is it possible to have the favicons in circles like the spec?  If not possible it's fine, just wanted to ask :) 

Thanks Kevin!
Attachment #8476449 - Flags: ui-review?(epang) → ui-review+
(In reply to Eric Pang [:epang] from comment #4)
> Can you check one thing?  The font size and colour of the history items seem
> to be off.  Once this is fixed I think we should be good.  I've R+ since I'm
> on PTO tomorrow.

I'll make these updates today.

> Also a side note, is it possible to have the favicons in circles like the
> spec?  If not possible it's fine, just wanted to ask :) 

I think we can try to revisit this after the "larger icons" lands. The problem right now is that all of our icons are 16x16. I don't really think we can make them circles, but after we have larger icons we may be able to make some circles depending if they are big enough. Or expand all of the smaller ones, though they may be pixelated.
In master: https://github.com/mozilla-b2g/gaia/commit/26709703fa02fc65617987971f209d1e49d3ca70
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.