1054914 - Deleting the autofilled portion of a URL should result in the first result being the current search engine

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

From bug 951624 comment 31:
> STR : 
> 1. type "face" in the awesomebar.
> 2. Awesomebar autocompletes to facebook.com
> 3. Hit backspace to have "face" again in the awesomebar.
> 
> CR : the first entry is still visit facebook.com
> 
> ER : the first entry change to search google for "face"

Unfortunately, I don't see a way to do with using the current autocomplete API.

We'd need to handle something here:
http://dxr.mozilla.org/mozilla-central/source/toolkit/components/autocomplete/nsAutoCompleteController.cpp#226

Comment 1

[Marco Bonardo [:mak]]

we should start by handling backspace properly... I wonder if my patch in bug 719888 would help... provided we should probably change the API and add handleBackspace rather than reusing handleNavigation like I did...

Comment 3

[u428464]

I'm glad that bug 1067903 has landed, but now backspace behavior is even more broken. Since the first entry is always selected sometimes you just have "face" typed in the awesomebar (after deleting the "book.com") but on hitting enter the visited site is still facebook.com even if you wanna search "face". It wasn't broken like that before.

Comment 5

[arni2033]

bug 1187747 is about NOT LOADING the page after you delete suggested text with BackSpace and then press Enter. Nothing happens in this case.
Either change the title of this bug or reopen that bug.

Anyway, this bug already has wrong title according to bug 1187753

Comment 6

[Marco Bonardo [:mak]]

(In reply to arni2033 from comment #5)
> bug 1187747 is about NOT LOADING the page after you delete suggested text
> with BackSpace and then press Enter. Nothing happens in this case.
> Either change the title of this bug or reopen that bug.

it doesn't happen anything because what should happen is what is expressed in this bug. If you prefer I can dupe to bug 1173202, but nothing changes in practice, all of these are just manifestations of the same bug, bug 1172937.

Comment 7

[Marco Bonardo [:mak]]

fixed by bug 1172937.