1054964 - [Flame][Flatfish][FTU] Unable to tap the "Join" button in FTU wifi settings.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[eva.chen.fx]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.143 Safari/537.36

Steps to reproduce:

1. Flash a fresh build on the tablet. 
2. Run the first time experience
3. On the network screen, choose a network that is password-protected
4. Type a password
5. Tap the Join button
6. <ISSUE> Unable to tap the "Join" button in FTU wifi settings.
-----------------------------------------------
Environment Info:
Gaia: deb73e71e32ccc26261de33d9f857ce5d429e2f6 (Date: Mon Aug 18 12:26:27 2014 +0200)
Gecko:1e2086d3a6f473b2437f25a4a9226b6c2d6c2605
B2G: 2.1.0.0-prerelease
Platform version : 34.0a1
Repro frequency: 100%


Actual results:

<ISSUE> The Join button doesn't work in FTU wifi settings.
* Flame devices has same issue.


Expected results:

The Join button function normally.

Comment 1

[Florin Strugariu [:Bebe]]

I'm able to reproduce this on the Flame device too using the latest build.

Str are the same as in the description.

I can reproduce this with manual tests and automation.

BuildID:

Gaia      aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko     https://hg.mozilla.org/mozilla-central/rev/0aaa2d3d15cc
BuildID   20140818040201
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230


Logcat error:

E/GeckoConsole( 3709): [JavaScript Error: "TypeError: newWifi.querySelector(...) is null" {file: "app://ftu.gaiamobile.org/gaia_build_defer_index.js" line: 458}]



Automated test that fails:

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/ftu/test_ftu_skip_tour.py

Comment 2

[Jason Smith [:jsmith]]

[Blocking Requested - why for this release]:

QA blocking issue for causing a permafail & a regression.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Tinderbox regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140816144415
Gaia: 325f68045e7abacdd80f28cce53315d469e82469
Gecko: 94ba78a42305
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140817120415
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 1a514d9b65fd
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

First broken gecko & last working gaia - issue does NOT repro
Gaia: 325f68045e7abacdd80f28cce53315d469e82469
Gecko: 1a514d9b65fd

First broken gaia & last working gecko - issue DOES repro
Gaia: aa8aace12d65956dd9525da5dac66e0d3b28597f
Gecko: 94ba78a42305

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/325f68045e7abacdd80f28cce53315d469e82469...aa8aace12d65956dd9525da5dac66e0d3b28597f

Caused by Bug 1052448 ?

Also flipped tracking flags to reflect Flame branch checking result.

Comment 4

[Joshua Mitchell (Inactive)]

Broken by bug 1052448 ? Can you take a look Yura?

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

When I corrected the markup order, the outdated selector, that was dependent on the order, became invalid. This should now be addressed.

Comment 7

[Fernando Campo (:fcampo)]

Comment on attachment 8475194 [details] [review]
Github pull request.

sorry for missing it on first review, but thanks for spotting it and quick fix!

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/ed5105c688682830885627f32f690224d4b957a7

Comment 10

[Roland Kunkel [:RolandK]]

I am unable to reproduce this issue in the latest 2.1 Flame build:

Enviromental Variables:
----------------------------------------
Device: Flame 2.1 Master
BuildID: 20140820040203
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Resolved as fixed.