105838 - Don't choose news identity when sending mail from non Mail Window

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[scottputterman]

This is a side effect of http://bugzilla.mozilla.org/show_bug.cgi?id=79053.

We now use the identity of the selected account in the mail window when
intiating a compose window from a place in the product that isn't mail.  In the
case where the currently selected account is news, I think we should use the
default mail identity.  I often find myself browsing and want to send something
to someone based on what I'm looking at and find myself stuck with a preselected
news identity and a newsgroup filled into the To field.

Steps:

1.  Read a newsgroup
2.  Go to the browser and bring up a compose window
3.  See that the identity is preselected to News and that the newsgroup is
filled into the To field.

I'd rather see the default identity.

Comment 1

[R.K.Aa.]

*** Bug 105832 has been marked as a duplicate of this bug. ***

Comment 2

[R.K.Aa.]

*** Bug 107347 has been marked as a duplicate of this bug. ***

Comment 3

[jglick]

Sounds good.

Comment 4

[scottputterman]

*** Bug 117216 has been marked as a duplicate of this bug. ***

Comment 5

[varada]

Do you want to use the default identity for all three cases - new message
window, send link and send page? or should the news identity be retained for any
of the three cases?

Comment 6

[Mike Shaver (:shaver emeritus)]

Personally, I think they should all behave the same way, and give you the
default identity.  The state of my mailnews window shouldn't affect the
behaviour of File->* in the navigator, to my mind.  Action at a distance is
confusing!

Comment 7

[varada]

Attachment: Patch V.1

This fix will ensure that the default identity is used when a new message
window is brought up from the browser (when the news server is selected in the
mail window).

Comment 8

[scottputterman]

It should affect all of the cases you mentioned.  I don't want my news identity
when I'm sending mail from another part of the app and I definitely don't want
to send to a newsgroup unless I explicitly choose to.

Comment 9

[jglick]

I agree.

Comment 10

[Jean-Francois Ducarroz]

Comment on attachment 69565 [details] [diff] [review]
Patch V.1

>+        var cwindowManager = Components.classes['@mozilla.org/rdf/datasource;1?name=window-mediator'].getService();
>+        var iwindowManager = Components.interfaces.nsIWindowMediator;
>+        var windowManager  = cwindowManager.QueryInterface(iwindowManager);
>+        var mailWindow = windowManager.getMostRecentWindow('mail:3pane');

If I am right, you could use instead the nsIMailSession to retreive the topmost
mail window.
BTW, The mostRecentWindow is by creation time, it will not necessary give you
the top most!

var mailSession =
Components.classes["@mozilla.org/messenger/services/session;1"].getService(Comp
onents.interfaces.nsIMsgMailSession);
if (mailSession)
 mailWindow = mailSession .topmostMsgWindow;
...


>+          var currentIdentity = getCurrentIdentityKey();
>+          if(currentIdentity)
>+            params.identity = currentIdentity;

could be just:
 params.identity = getCurrentIdentityKey();

Comment 11

[varada]

Attachment: Patch V.2

I have tested and spoken to Jean Francois about it and found that
windowManager.getMostRecentWindow('mail:3pane') does return the most recently
active mail window. I have modified the patch to 
params.identity = getCurrentIdentityKey();

Comment 12

[Jean-Francois Ducarroz]

Comment on attachment 69770 [details] [diff] [review]
Patch V.2

R=ducarroz

Comment 13

[Scott MacGregor]

Comment on attachment 69770 [details] [diff] [review]
Patch V.2

sr=mscott

Comment 14

[varada]

Marking Fixed.

Comment 15

[Ninoschka Baca]

Trunk build 2002-03-01: WinMe, Linux RH 7.1, Mac 9.1
Verified Fixed, it now selects the default Mail Identity.