1058708 - [e10s] View Page Source of context menu does not work in e10s

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

+++ This bug was initially created as a clone of Bug #1058539 +++

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch

try: https://tbpl.mozilla.org/?tree=Try&rev=0ab627c312a1

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8479209 [details] [diff] [review]
patch

I'm pretty sure this is going to break for non-e10s windows, since gContextMenu.browser.contentDocumentAsCPOW will return undefined in that case.

Comment 3

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

(In reply to Mike Conley (:mconley) from comment #2)
> I'm pretty sure this is going to break for non-e10s windows, since
> gContextMenu.browser.contentDocumentAsCPOW will return undefined in that
> case.

If you say so, does this code has same risk for non-e10s windows?
http://dxr.mozilla.org/mozilla-central/source/browser/base/content/browser-sets.inc#41

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hm... maybe I'm wrong on that. That code you've pointed out certainly contradicts what I said. Let me run a few experiments and get back to you.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8479209 [details] [diff] [review]
patch

Ah, yes, sorry - I was testing with an older build that didn't have billm's AsCPOW work in it, so of course it was undefined.

My apologies. Yes, this should work fine for now until we have a better solution that doesn't involve CPOWs.

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Thank you r+, Mike.

At the current rule, can I land the patch after https://tbpl.mozilla.org/?tree=Try&rev=0ab627c312a1 finished?

Comment 7

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

https://hg.mozilla.org/integration/fx-team/rev/11930a45d9a7

Comment 8

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

https://hg.mozilla.org/mozilla-central/rev/11930a45d9a7

Comment 9

[Flaviu Cos]

I can reproduce the bug on Nightly build from: 2014-08-26;

The bug is no longer reproducible on latest Nightly build 2014-11-06;