crash in java.lang.IllegalStateException: Already registered Wifi:Enable at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)

VERIFIED FIXED in Firefox 34

Status

()

Firefox for Android
General
--
critical
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: aaronmt, Assigned: wesj)

Tracking

(Depends on: 1 bug, {crash})

unspecified
Firefox 35
All
Android
crash
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox32 unaffected, firefox33 unaffected, firefox34+ verified, firefox35 verified, fennec34+)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
This bug was filed from the Socorro interface and is 
report bp-54fb5d73-0a1a-4c58-879a-0f3722140830.
=============================================================

java.lang.IllegalStateException: Already registered Wifi:Enable
	at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java:70)
	at org.mozilla.gecko.EventDispatcher.registerGeckoThreadListener(EventDispatcher.java:118)
	at org.mozilla.gecko.GeckoNetworkManager.start(GeckoNetworkManager.java:100)
	at org.mozilla.gecko.GeckoApplication.onActivityResume$642b2292(GeckoApplication.java:113)
	at org.mozilla.gecko.GeckoActivity.onResume(GeckoActivity.java:38)
	at org.mozilla.gecko.GeckoApp.onResume(GeckoApp.java:1925)
	at org.mozilla.gecko.BrowserApp.onResume(BrowserApp.java:669)
	at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1210)
	at android.app.Activity.performResume(Activity.java:5505)
	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2936)
	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2975)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1307)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:157)
	at android.app.ActivityThread.main(ActivityThread.java:5356)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1265)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1081)
	at dalvik.system.NativeStart.main(Native Method)
(Assignee)

Comment 2

3 years ago
Created attachment 8483043 [details] [diff] [review]
Patch

Apparently we can call start() multiple times without calling stop(). Start is called in onResume. Stop is called in onPause(). The two should be matched.... so I'm not sure how this happens.

This patch moves these to the constructor/onDestory, but it doesn't really answer the question.
Attachment #8483043 - Flags: review?(mark.finkle)
Attachment #8483043 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 4

3 years ago
Comment on attachment 8483043 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1042196
[User impact if declined]: Potential crashes
[Describe test coverage new/current, TBPL]: Still not exactly sure why this happened, but this is a better way of doing this regardless.
[Risks and why]: low risk. This is a singleton, so this doing this in the constructor enforces pretty strongly that it only happens once.
[String/UUID change made/needed]: none
Attachment #8483043 - Flags: approval-mozilla-aurora?
status-firefox32: --- → unaffected
status-firefox33: --- → unaffected
status-firefox35: --- → affected
tracking-firefox34: --- → +
https://hg.mozilla.org/mozilla-central/rev/8a5f6d1f4882
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
tracking-fennec: ? → 34+
(Reporter)

Updated

3 years ago
Depends on: 1063541
status-firefox35: affected → fixed
Comment on attachment 8483043 [details] [diff] [review]
Patch

Aurora+
Attachment #8483043 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Reporter)

Updated

3 years ago
Depends on: 1074620
(Reporter)

Updated

3 years ago
Depends on: 1074187
(Reporter)

Updated

3 years ago
No longer blocks: 1074188
Depends on: 1074188
I'm marking this bug verified fixed as there are have been no crashes reported in the last week.
Status: RESOLVED → VERIFIED
status-firefox34: fixed → verified
status-firefox35: fixed → verified
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.