1061030 - crash in java.lang.IllegalStateException: Already registered Wifi:Enable at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-54fb5d73-0a1a-4c58-879a-0f3722140830.
=============================================================

java.lang.IllegalStateException: Already registered Wifi:Enable
	at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java:70)
	at org.mozilla.gecko.EventDispatcher.registerGeckoThreadListener(EventDispatcher.java:118)
	at org.mozilla.gecko.GeckoNetworkManager.start(GeckoNetworkManager.java:100)
	at org.mozilla.gecko.GeckoApplication.onActivityResume$642b2292(GeckoApplication.java:113)
	at org.mozilla.gecko.GeckoActivity.onResume(GeckoActivity.java:38)
	at org.mozilla.gecko.GeckoApp.onResume(GeckoApp.java:1925)
	at org.mozilla.gecko.BrowserApp.onResume(BrowserApp.java:669)
	at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1210)
	at android.app.Activity.performResume(Activity.java:5505)
	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2936)
	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2975)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1307)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:157)
	at android.app.ActivityThread.main(ActivityThread.java:5356)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1265)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1081)
	at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Robert Kaiser]

All those crashes seem to be on 34.0a1 nightly when looking at https://crash-stats.mozilla.com/report/list?product=FennecAndroid&signature=java.lang.IllegalStateException%3A+Already+registered+Wifi%3AEnable+at+org.mozilla.gecko.EventDispatcher.registerListener%28EventDispatcher.java%29

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Apparently we can call start() multiple times without calling stop(). Start is called in onResume. Stop is called in onPause(). The two should be matched.... so I'm not sure how this happens.

This patch moves these to the constructor/onDestory, but it doesn't really answer the question.

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/8a5f6d1f4882

Comment 4

[Wesley Johnston (:wesj)]

Comment on attachment 8483043 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1042196
[User impact if declined]: Potential crashes
[Describe test coverage new/current, TBPL]: Still not exactly sure why this happened, but this is a better way of doing this regardless.
[Risks and why]: low risk. This is a singleton, so this doing this in the constructor enforces pretty strongly that it only happens once.
[String/UUID change made/needed]: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8a5f6d1f4882

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8483043 [details] [diff] [review]
Patch

Aurora+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/60e0c4dac4b1

Comment 8

[u279076]

I'm marking this bug verified fixed as there are have been no crashes reported in the last week.