1074189 - crash in java.lang.NullPointerException: at org.mozilla.gecko.GeckoApplication.onActivityResume$642b2292(GeckoApplication.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-dca990ac-c5ea-4e3a-9811-924de2140928.
=============================================================

java.lang.NullPointerException
	at org.mozilla.gecko.GeckoApplication.onActivityResume$642b2292(GeckoApplication.java:113)
	at org.mozilla.gecko.GeckoActivity.onResume(GeckoActivity.java:38)
	at org.mozilla.gecko.GeckoApp.onResume(GeckoApp.java:1853)
	at org.mozilla.gecko.BrowserApp.onResume(BrowserApp.java:755)
	at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1192)
	at android.app.Activity.performResume(Activity.java:5310)
	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2802)
	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2841)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2276)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:3762)
	at android.app.ActivityThread.access$900(ActivityThread.java:144)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1211)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5146)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:732)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:566)
	at dalvik.system.NativeStart.main(Native Method)

Sudden surge of crashes with onActivityResume over the weekend

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

jchen tried to warn me here. I'm not sure why I didn't check this.

Comment 3

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/85ca6a8ab234

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/85ca6a8ab234

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8497071 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1063541
[User impact if declined]: Fixes a crash when switching back and forth between apps (in some cases)
[Describe test coverage new/current, TBPL]: Really hard to test (need to kill/restart activities) during tests.
[Risks and why]: Low risk. Makes this lazy loader work.
[String/UUID change made/needed]: none.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8497071 [details] [diff] [review]
Patch

Given that this is really hard to test and bug 1063541 will be uplifted shortly, let's take this on Aurora now. Aurora+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/33ccccf7550b

Comment 9

[u279076]

Assuming verified fixed since there have been 0 reports of this crash in the last week.