1061400 - Fix DecodersContainTime issue from bug 1058428

Status: RESOLVED DUPLICATE of bug 1059058

(Core :: Audio/Video, defect)

Description

[cajbir (:cajbir)]

Spawned from bug 1058428. This is a workaround to more closely implement that mentioned in bug 1058428 comment 2. The full fix for this is bug 1059058 but that is not yet ready for landing and this fix gets youtube seeking mostly working in the meantime.

Comment 1

[cajbir (:cajbir)]

Attachment: Fix DecodersContainTime issue from bug 1058428

Comment 2

[cajbir (:cajbir)]

Attachment: Workaround VP9 invalid frame buffer error when decoding MSE

The current state of WebM decoding via MSE gives intermittent 'invalid frame buffer' errors when in WebMReader::DecodeVideoFrame after seeking. The current handling of this error is to abandon decoding. 

Decoding continues if we attempt to resume decoding so the workaround here is to do that. This gets seeking working on WebM until we track down the cause of the error. Bug 1061402 is raised to track the issue.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8482495 [details] [diff] [review]
Workaround VP9 invalid frame buffer error when decoding MSE

There is no way we're landing this.

Comment 4

[cajbir (:cajbir)]

Attachment: SwitchReaders refactoring

This patch is equivalent to that in bug 1059058 attachment 8481053 [details] [diff] [review] and is what I was using for my workarounds to get seeking to work. Uploaded here so it doesn't get lost until the former lands/is finished.

Patch queue required for working seeking is:

mozilla-central
bug 1061007
bug 1059058 attachment 8481052 [details] [diff] [review]
bug 1062020
bug 1062018
this bug
bug 1059058 attachment 8481092 [details] [diff] [review]
bug 1062023

Bug 1062055 is the most prominent remaining that I hit.

Comment 5

[Matthew Gregan [:kinetik]]

Bug 1059058 is now in m-c, so resolving this.